New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching regional map of a higher level structure from desired granularity is not possible #372

Open

AhmetNSimsek opened this issue May 5, 2023 · 1 comment

Labels

Collaborator

AhmetNSimsek commented May 5, 2023

import siibra  # as of v0.4a48
p = siibra.parcellations["julich 3.0"]
r = p.get_region("Subiculum (Hippocampus)")

# This will not go through the higher granularity since children of "Subiculum (Hippocampus)" are mapped in 157 region map.
r.fetch_regional_map("mni152", maptype="statistical")

AhmetNSimsek added the enhancement label

Collaborator Author

AhmetNSimsek commented May 11, 2023 •

edited

Loading

Suggestion: add map_spec: str = "" keyword argument that adds the check for extra specififcation ie:

if (
    m.space.matches(fetch_space) and
    m.parcellation == self.parcellation and
    m.provides_image and
    m.maptype == maptype and
    self.name in m.regions and
    map_spec in m.name
):

@dickscheid, do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment