Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receptor density finger print value missing #121

Open
xgui3783 opened this issue Mar 20, 2023 · 5 comments
Open

Receptor density finger print value missing #121

xgui3783 opened this issue Mar 20, 2023 · 5 comments

Comments

@AhmetNSimsek AhmetNSimsek changed the title [bug] receptor density finger print value missing Receptor density finger print value missing Apr 3, 2023
@AhmetNSimsek
Copy link
Collaborator

Prof. Nicola Palomero-Gallagher is one of the custodians of the dataset. I've just informed her via email.

@AhmetNSimsek
Copy link
Collaborator

She has informed me that there is only one data point for alpha2 and hence the field is skipped.
Should we ask for a change to Nan? What do you think @xgui3783?

@xgui3783
Copy link
Member Author

xgui3783 commented Apr 13, 2023

pandas actually automatically add NaN

but this poses a problem to:

  • data serialization (I will have to add NaN to a possible value, and also, since NaN is not a valid json data type, encode it as null instead)
  • data visualization (polar plot assumes mean & std are both present. with one missing the behavior is undefined)

@AhmetNSimsek
Copy link
Collaborator

@xgui3783, then should we carry this to siibra-explorer?
Is there anything that could help from siibra-python side?

@xgui3783 xgui3783 transferred this issue from FZJ-INM1-BDA/siibra-python Apr 18, 2023
@xgui3783
Copy link
Member Author

xgui3783 commented Apr 18, 2023

I have transferred the issue to siibra-api.

I need to add:

  • serialization of NaN to null
  • serialization of df to possibly contain null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants