Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTB Quests - EMI integration #9

Draft
wants to merge 2 commits into
base: 1.19/dev
Choose a base branch
from

Conversation

unilock
Copy link

@unilock unilock commented Sep 7, 2023

This PR adds integration with EMI, a new-ish recipe viewer, to FTB Quests. Fixes FTBTeam/FTB-Mods-Issues#312.

TODO:

  • Clicking items in the Quest Book UI opens EMI
  • Display quest rewards in EMI under a new category
    • Fix category sometimes not appearing in EMI until after /reload - seems to be dependent on mod load order? (which, afaik, is random in Fabric)
    • Center the quest title text
    • Maybe use something other than our own ClickableTextWidget for opening the quest book from EMI?
  • Display "loot crates" in EMI under a new category

Note: the modpack I'm using for testing is @sisby-folk's Tinkerer's Quilt.

Sometimes only works after /reload?

Signed-off-by: unilock <[email protected]>
@desht
Copy link
Contributor

desht commented Sep 7, 2023

I'll be following this with interest, thanks for taking the time on this. Feel free to tag me with any questions, if needed.

@Spongman
Copy link

Spongman commented Jun 1, 2024

can you also add EMI bookmark support directly from the quest 'Tasks' or 'Valid Items' page ?

@Kevin-Marsh
Copy link

I will be curious to see how this goes. A few mods have dropped JEI support in 1.21 which has basically forced the adoption of EMI with ATM10 using straight EMI to start out and Enigmatica 10 using a combination of JEI and EMI.

@unilock
Copy link
Author

unilock commented Jul 6, 2024

@Spongman

can you also add EMI bookmark support directly from the quest 'Tasks' or 'Valid Items' page ?

This is not something EMI exposes an API for, currently.

@Ftrless
Copy link

Ftrless commented Jul 11, 2024

@unilock Do you have any ideas on how to make it so that instead of opening inventory, pressing ESC opens the quest from where the recipe display was opened, if at all possible?

@MycahBrooks
Copy link

hey! is this PR still being worked on?

@sarpuser
Copy link

I am also very interested in this pull request.

@SanQianQVQ
Copy link

I'm not sure if the problem has been solved, because I still encounter this problem
emi-1.1.12+1.20.1+fabric
ftb-quests-fabric-2001.4.8
ftb-xmod-compat-fabric-2.1.1
Frustrating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants