Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute path problem in launch file #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmo73
Copy link

@pmo73 pmo73 commented Jun 26, 2023

This is a suggestion, how the problem with the absolute path can be fixed for ros2. With this solution it should be possible to run the simulator with ros2 in every directory

@wouter-heerwegh
Copy link
Member

Hi @pmo73,

Sorry for the late reply

It seems like the PR is just trying to change the hardcoded path from the default ~/Formula-Student-Driverless-Simulator/settings.json directory to a different one. We changed the behaviour of how the settings file is loaded in #314 and #324, but we seemed to have forgotten that the camera's are loaded differently.

I think a better solution would be to use the python api to connect to the RPC server of the sim and call the getSettingsString function to get the actual settings from the sim. This way, there is no mismatch between the sim and a possible duplicate settings.json file.

Feel free to give some feedback.

@pmo73
Copy link
Author

pmo73 commented Jan 13, 2024

Hi @wouter-heerwegh , unfortunately I no longer have Unreal Engine installed to try this out. So I would close the PR. I was not aware that there is an RPC server that can be used to solve the problem.

@wouter-heerwegh
Copy link
Member

Hi @pmo73,

I'll leave it open for now, and I'll try to look at it in the future.

@wouter-heerwegh wouter-heerwegh self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants