Revamp logging with RootLogHandler and new logger config #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented TaskLogHandler for thread-specific log queues - Added LoggerSettings and LoggerConfig classes
- Refactored TaskLogHandler to RootLogHandler for improved clarity. - Refined configuration settings for the logger. - Added workflow and worker examples to demonstrate logging capabilities. - Adjusted main to work with the new logger setup.
- env variable name: UNICONFIG_KEY_DELIMITER - default value: %22 - add function: escape_uniconfig_uri_key
…to feature/logging-enhancements # Conflicts: # poetry.lock
jaro0149
approved these changes
Sep 10, 2024
jaro0149
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
Added
RootLogHandler:Introduced a new handler to manage root-level logging, which also utilizes thread-specific queues for logs from tasks in
frinx_conductor_wrapper.Introduced
LoggerSettingsandLoggerConfig:Introduced classes that streamline the logger setup process, enhancing flexibility and maintainability.
Updated Workflow and Worker Examples:
Created new examples to test and showcase the capabilities of the revamped logging configuration within the
Test_workflow / 1workflow.Adjusted Main Code:
Modified
main.pyin the example folder to integrate with the new logger setup.