Add support for UC 5.2.X #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirohudec
requested review from
lhajabacs and
Jozefiel
and removed request for
lhajabacs
mirohudec
force-pushed
the
uc_5_2_X
branch
2 times, most recently
from
f82dd86
to
a442a15
Compare
Jozefiel
approved these changes
Feb 28, 2024
Jozefiel
reviewed
Feb 28, 2024
| @@ -156,8 +171,8 @@ def test_mount_existing_device(self): | |||
| request["output"]["url"], | |||
| uniconfig_url_base + "/operations/connection-manager:install-node", | |||
| ) | |||
| self.assertEqual(request["output"]["response_code"], 204) | |||
| self.assertEqual(request["output"]["response_body"], {}) | |||
| self.assertEqual(request["output"]["response_code"], 409) | |||
There was a problem hiding this comment.
is 409 ok status code? just to be sure
There was a problem hiding this comment.
Based on the code it seems that if the node was already installed the task should end successfully.
UC 5.2.7 sends 409 for that scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify workers to support UC 5.2.X and reformat code using black.
Checklist