forked from Netflix/conductor
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency update #178
Open
JumasJM
wants to merge
3
commits into
master
Choose a base branch
from
dependency_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dependency update #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrading OSS libraries with known open CVEs * Updating the protobuf library. * Resolve the remaining build issues. --------- Co-authored-by: Scott Carter <[email protected]>
JumasJM
force-pushed
the
dependency_update
branch
from
September 20, 2024 13:19
c18d087
to
2d02d23
Compare
- dependency.lock files will be removed when pulling updates from upstream type: Impovement
- update spring boot to 3.1.11 - updated dependency version accordingly to spring boot 3.1.11 - some javax libraries are still present due to compatibility - added entityManagement config beans - majority of dependency.lock files removed - updated tests accoringly to upstream changes type: Impovement
JumasJM
force-pushed
the
dependency_update
branch
from
September 30, 2024 09:11
2d02d23
to
28cacb6
Compare
Vasyl-9
requested changes
Oct 2, 2024
@@ -5,11 +5,11 @@ sourceSets { | |||
|
|||
dependencies { | |||
implementation project(':conductor-annotations') | |||
api 'com.google.guava:guava:32.1.2-jre' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you add // at the end of the 8 line?
@@ -16,6 +16,9 @@ conductor.db.type=postgres | |||
spring.datasource.url=jdbc:postgresql://localhost:5432/postgres?charset=utf8&parseTime=true&interpolateParams=true | |||
spring.datasource.username=postgres | |||
spring.datasource.password=postgres | |||
spring.jpa.hibernate.ddl-auto=update | |||
spring.jpa.show-sql=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not enable SQL queries in production logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: Improvement