Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update #178

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dependency update #178

wants to merge 3 commits into from

Conversation

JumasJM
Copy link
Collaborator

@JumasJM JumasJM commented Sep 20, 2024

  • dependencies.lock files will be removed when pulling updates from upstream

type: Improvement

* Upgrading OSS libraries with known open CVEs

* Updating the protobuf library.

* Resolve the remaining build issues.

---------

Co-authored-by: Scott Carter <[email protected]>
- dependency.lock files will be removed when pulling updates from upstream

type: Impovement
- update spring boot to 3.1.11
- updated dependency version accordingly to spring boot 3.1.11
- some javax libraries are still present due to compatibility
- added entityManagement config beans
- majority of dependency.lock files removed
- updated tests accoringly to upstream changes

type: Impovement
@@ -5,11 +5,11 @@ sourceSets {

dependencies {
implementation project(':conductor-annotations')
api 'com.google.guava:guava:32.1.2-jre'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add // at the end of the 8 line?

@@ -16,6 +16,9 @@ conductor.db.type=postgres
spring.datasource.url=jdbc:postgresql://localhost:5432/postgres?charset=utf8&parseTime=true&interpolateParams=true
spring.datasource.username=postgres
spring.datasource.password=postgres
spring.jpa.hibernate.ddl-auto=update
spring.jpa.show-sql=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not enable SQL queries in production logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants