Changes to SmartIntake, need to be confirmed and pushed to master #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Harsh-Sinha Please review. - Nick & Sid |
Harsh-Sinha
requested changes
Feb 20, 2024
| default: | ||
| m_SmartIntakeFlag = false; |
There was a problem hiding this comment.
This should not be in the default case. Make an explicit case for switching over to false. We use the default case to do nothing
| break; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| switch (m_IntakeState) | ||
| { | ||
| case 0: | ||
| case 2: |
There was a problem hiding this comment.
this should start at case 0.
| { | ||
| /* code */ | ||
| input.intakeInput.runIntakeIn = true; |
There was a problem hiding this comment.
checking if the laser hit should be in the true case. The if statement should conditionally transfer to the false case
| default: | ||
| m_SmartOutTakeFlag = false; |
There was a problem hiding this comment.
see associated comment for intake
| @@ -159,15 +125,18 @@ void SmartIntake::HandleInput(RobotControlData& input){ | |||
|
|
|||
| switch (m_OutTakeState) | |||
| { | |||
| case 0: | |||
| case 2: | |||
There was a problem hiding this comment.
see associated comment for intake
| { | ||
| /* code */ | ||
| input.intakeInput.runIntakeOut = true; |
There was a problem hiding this comment.
see associated comment for intake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Siddhant