Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing non power of 2 mux generation #242

Merged

Conversation

KelvinChung2000
Copy link
Collaborator

@KelvinChung2000 KelvinChung2000 commented Oct 21, 2024

Now can correctly generate non power of 2 mux.

 //switch matrix multiplexer E6BEG4 MUX-5
assign E6BEG4_input = {A_O,W6END3,WW4END3,W1END2,W1END0};
cus_mux81_buf inst_cus_mux81_buf_E6BEG4 (
    .A0(E6BEG4_input[0]),
    .A1(E6BEG4_input[1]),
    .A2(E6BEG4_input[2]),
    .A3(E6BEG4_input[3]),
    .A4(E6BEG4_input[4]),
    .A5(GND0),
    .A6(GND0),
    .A7(GND0),
    .S0(ConfigBits[76+0]),
    .S0N(ConfigBits_N[76+0]),
    .S1(ConfigBits[76+1]),
    .S1N(ConfigBits_N[76+1]),
    .S2(ConfigBits[76+2]),
    .S2N(ConfigBits_N[76+2]),
    .X(E6BEG4)
);

I have also updated the name of the my_mux2 to cus_mux21, to make them follow the same naming conversion for the other muxes.

@KelvinChung2000 KelvinChung2000 marked this pull request as draft October 21, 2024 21:09
@KelvinChung2000 KelvinChung2000 marked this pull request as ready for review October 25, 2024 13:31
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run some tests and the general output looks good.
I compared the default Fabric with the current dev branch, also looks good.

I currently try to run an equivalence check of the outputs with yosys, but this seems to run for a long time. But this is more out of curiosity and for future testing.

But there is one thing, it would be nice if you maybe squash your commits together and provide a meaningful commit message, why this was changed.
For changes like this, it could be good to know on a later point, why this was changed.

@KelvinChung2000
Copy link
Collaborator Author

KelvinChung2000 commented Oct 30, 2024 via email

@EverythingElseWasAlreadyTaken
Copy link
Collaborator

The repo is default to squash and merge when merging which will use the pull request title as the commit message.

Sorry, I forgot about this feature!

@KelvinChung2000 KelvinChung2000 merged commit 07222cf into FPGA-Research:FABulous2.0-development Nov 4, 2024
2 checks passed
KelvinChung2000 added a commit to KelvinChung2000/FABulous that referenced this pull request Nov 13, 2024
KelvinChung2000 added a commit to KelvinChung2000/FABulous that referenced this pull request Jan 6, 2025
* mux fix

* formatting and rename my_mux2 to cus_mux21_buf

* rename and update for vhdl

* more rename

---------

Co-authored-by: King Lok Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants