-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation of MID wires #167
Add documentation of MID wires #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just a couple of minor suggested tweaks. Thanks for this!
Hi folks, |
fix typo Co-authored-by: Bea Healy <[email protected]>
resolve ambiguity Co-authored-by: Bea Healy <[email protected]>
@dirk-koch We are not planning to remove the MID ports but rather wanted to add some documentation for them, since not everyone might be as familar with the Xilinx stuff as you are ;D With that said, do you agree with the short description that was added? Or is there anything you would improve or add? |
@IAmMarcelJung I got the go-ahead from Dirk so I'll get this merged! |
Nice, thanks! |
This would resolve #140. The image is a screenshot taken from inside FABulator. Although it might not be the best visualization due to the thin wires, it's something and maybe could be replaced in the future. Either by an updated version if thicker lines are supported or if somebody wants to draw an image themselves, this would also to the trick.
The explanation might also be a bit flawed but this is as far as I understood it from explanation by @dirk-koch and the visualization of FABulator. Also I'm not sure if I inserted the content into the correct place in the text.
As always, any feedback is therefore highly appreciated!