Prevent FABulous crash by checking for existing directory in do_place_and_rout_npnr #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoBi22
approved these changes
Nov 10, 2023
|
Okay, thanks for your feedback! |
KelvinChung2000
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if the specified directory exists and therefore prevents the CLI from crashing in
if f"{name}.json" in os.listdir(f"{self.projectDir}/{path}"):if the specified directory does not exist.I don't know why git marks so many lines as changed, since I only added a surrounding
ifand an additionalelse. Is this just do to the indention on python or is it my mistake? Sorry if the latter is the case and please tell me how an can correct it in that case.