Add exception handling for the synthesis CLI commands #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoBi22
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Looks good to me! I also had issues with this testing #128 - I would guess it's probably worth making similar changes to the nextpnr call as well but I'm happy to put that in another PR. Requested review from Kelvin too since he wrote the CLI.
KelvinChung2000
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI always crashed when there was an error during synthesis (e.g. file not found or error in files). The traceback also "hid" the error with its output a few lines above. Now the user just gets notified that the synthesis failed, the error is just above the short logging message and the CLI does not crash so the user does not have to restart FABulous and reload the fabric after fixing the error. If it was just a typo in the path or file, the mistake can just be corrected from the history without completely retyping the command which is necessary after restarting FABulous.