Fix file name of the bitstream specification file in the documentation. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I revoked the change of the FASM file name since gen_bitstream_binary uses a "_gen.fasm" file for the bitstream generation, but does expect just a ".fasm" file to be specified in the command and adds the "_gen" internally. |
TaoBi22
approved these changes
Nov 10, 2023
Co-authored-by: Bea Healy <[email protected]>
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file "meta_data.txt" does not seem to exist even after the flow is complete and the command works with "bitStreamSpec.bin". This file is also used in the function do_gen_bitStream_binary in FABulous.py.