Exception derived class created #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
help me to create the custom error :D |
twentyse7en
reviewed
Sep 30, 2020
| @@ -0,0 +1,60 @@ | |||
| # Default ignored files | |||
| /shelf/ | |||
There was a problem hiding this comment.
What code editor do you use? I think we can create minimal .gitignore.
| @@ -2,6 +2,7 @@ | |||
| from token_type import TokenType | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Avoid adding extra space and removing space, you can use autopep8 or similar extension in the code editor.
|
|
||
| # raise Error | ||
| #FIX THIS ERROR | ||
| class Error(Exception): |
There was a problem hiding this comment.
You can move the Error class outside the Scanner class. It would be better to rename the error, the error name which relates to scanner would be good. Do we need def __init__(...)? I think inheriting the Exception takes care of that.
There was a problem hiding this comment.
Thanks for your suggestions @twentyse7en :D.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm trying to create custom error.