Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcc 13 changes (#include <cstdint>) #41

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Gcc 13 changes (#include <cstdint>) #41

merged 3 commits into from
Nov 13, 2023

Conversation

marcmengel
Copy link
Collaborator

@marcmengel marcmengel commented Oct 27, 2023

Larsoft changes for gcc13

I have now built larsoft with these twice on SL7, with the v0.21.0-dev.fermi spack branch.

@marcmengel marcmengel changed the title Gcc 13 changes (include <stdint>) Gcc 13 changes (#include <cstdint>) Oct 28, 2023
Comment on lines 60 to 62

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraneous space?

Copy link
Member

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those external packages requiring def patch(self) and/or filter_file() could you check if recent versions are fixed and apply @when or similar as appropriate?

@greenc-FNAL
Copy link
Member

@marcmengel LGTM: go ahead and merge when you're ready.

@marcmengel marcmengel merged commit 6f12e35 into master Nov 13, 2023
2 checks passed
@marcmengel marcmengel deleted the gcc_13_cstdint branch November 13, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants