Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in parsing function arguments #19

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix typo in parsing function arguments #19

merged 1 commit into from
Jan 29, 2024

Conversation

knoepfel
Copy link
Collaborator

Also includes adjustment to Findifhc.cmake to support Spack.

@knoepfel knoepfel requested a review from greenc-FNAL January 29, 2024 19:26
Copy link
Member

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greenc-FNAL greenc-FNAL merged commit 485e4f4 into develop Jan 29, 2024
2 checks passed
@knoepfel knoepfel deleted the minor-fixes branch January 29, 2024 20:12
greenc-FNAL added a commit that referenced this pull request Jan 29, 2024
Bug fixes:

* In `cet_publish_sphinx_html()`, define `_cps_is_numeric` in the scope
  in which it is used.

* Fix thinko in implementation of `cet_localize_pv_all()`.

* Fix argument handling affecting behavior of `build_dictionary()` since
  3.23.00 (PR #19).

Features and improvements:

* `cet_test()` now adjusts `CMAKE_PREFIX_PATH` automatically for
  `COMPILE_ONLY` tests (PR #17).

* New function `cet_transitive_paths()` to collect and localize paths in
  project variables across all transitive dependencies of a given
  project (PR #18).

* When utilizing version switching for documentation, ensure
  `latest-version` is set even absent a numeric version.

* `Findifdhc.cmake` is more versatile about finding `ifdh.h` (PR #19).

* Change `BUILD_DOCS` global option `ON` -> `OFF`.

* `cet_localize_pv()`: new options `BINARY`, `SOURCE`, `TRY_BINARY`, and
  `NO_CHECK_VALIDITY`.

* `cet_localize_pv()` operates only on the `CACHE`d value of the project
  variable to avoid hysteresis.

* Minor improvements to documentation.
greenc-FNAL added a commit that referenced this pull request Jan 29, 2024
3.24.00

Bug fixes:

* In `cet_publish_sphinx_html()`, define `_cps_is_numeric` in the scope
  in which it is used.

* Fix thinko in implementation of `cet_localize_pv_all()`.

* Fix argument handling affecting behavior of `build_dictionary()` since
  3.23.00 (PR #19).

Features and improvements:

* `cet_test()` now adjusts `CMAKE_PREFIX_PATH` automatically for
  `COMPILE_ONLY` tests (PR #17).

* New function `cet_transitive_paths()` to collect and localize paths in
  project variables across all transitive dependencies of a given
  project (PR #18).

* When utilizing version switching for documentation, ensure
  `latest-version` is set even absent a numeric version.

* `Findifdhc.cmake` is more versatile about finding `ifdh.h` (PR #19).

* Change `BUILD_DOCS` global option `ON` -> `OFF`.

* `cet_localize_pv()`: new options `BINARY`, `SOURCE`, `TRY_BINARY`, and
  `NO_CHECK_VALIDITY`.

* `cet_localize_pv()` operates only on the `CACHE`d value of the project
  variable to avoid hysteresis.

* Minor improvements to documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants