[windows] List all audio devices for Windows #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steelskin
force-pushed
the
win-list-all-devices
branch
from
ac5a389
to
4ca5f0f
Compare
Previously, FAudio with `PLATFORM_WIN32` would only list the default audio device. This reworks the Faudio `PLATFORM_WIN32` code to enable access to every audio device on the system. In order to preserve the existing behavior (and Xaudio2 compabitility), the audio devices are re-ordered so the first device is always the default one. In addition, this properly populates the `DisplayName` field in `FAudioDeviceDetails`. Previously, it was set to the device GUID. Test: Local build with visualboyadvance-m
Steelskin
force-pushed
the
win-list-all-devices
branch
from
4ca5f0f
to
eb0b982
Compare
|
Friendly ping. Do you have any concern or issue with this PR? |
|
I don't personally, but this is code meant for Wine so I was hoping it would get reviewed over there... we may need to submit this as a patch to Wine first? Here's their local copy: https://gitlab.winehq.org/wine/wine/-/tree/master/libs/faudio?ref_type=heads |
|
Sorry, I missed the ping. I'll have a look. |
rbernon
reviewed
May 22, 2024
* Rework `FAudio_DefaultDeviceIndex` to return the Windows API error code and take the `defaultDeviceIndex` as parameter. * Change included headers for wine compatibility.
Steelskin
commented
May 23, 2024
rbernon
reviewed
May 23, 2024
|
We can be pretty picky about style, but that can always come through as style fix commits - will get this in now since it's been waiting so patiently! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, FAudio with
PLATFORM_WIN32would only list the default audio device. This reworks the FaudioPLATFORM_WIN32code to enable access to every audio device on the system. In order to preserve the existing behavior (and Xaudio2 compabitility), the audio devices are re-ordered so the first device is always the default one.In addition, this properly populates the
DisplayNamefield inFAudioDeviceDetails. Previously, it was set to the device GUID.Test: Local build with visualboyadvance-m