build: fix __attribute__((aligned(x))) on gcc/clang #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't safe AFAIK, but we've been using this for some time now... I'll forward this to the Apple peoples on the FNA Discord to see what might be up. |
|
Would you support selectively increasing the C standard to 11 only on clang for the time being? |
|
That would probably be okay, though we're still trying to figure out if there's a way to make this work correctly on M1. Will make the call this weekend! |
11 tasks
|
@rkitover, did this exist prior to the other change, or is it a regression? How does it manifest? Crash? Corrupted audio? Is this specific to M1? Wouldn't it affect iOS/tvOS as well? |
This is a followup on 81d5a24 (build: fix building with MSVC, 2024-03-07). Fix the missing trailing _ in __attribute__ for __attribute((aligned(x))). Signed-off-by: Rafael Kitover <[email protected]>
rkitover
force-pushed
the
msvc-build-clang-followup
branch
from
a14ec75
to
1078a67
Compare
|
@flibitijibibo I'm sorry, but this was all caused because I made a typo, I wrote |
rkitover
added a commit
to rkitover/vcpkg
that referenced
this pull request
Mar 9, 2024
Add new port FAudio, an "accuracy-focused XAudio reimplementation for open platforms". Use the PLATFORM_WIN32 cmake flag on Windows, otherwise use the sdl2 dependency. MSVC build PR is here: FNA-XNA/FAudio#333 , followup PR to fix alignment is here: FNA-XNA/FAudio#334 , MSYS2 package is here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-faudio/PKGBUILD . Signed-off-by: Rafael Kitover <[email protected]>
rkitover
changed the title
rkitover
added a commit
to rkitover/vcpkg
that referenced
this pull request
Mar 10, 2024
Add new port FAudio, an "accuracy-focused XAudio reimplementation for open platforms". Use the PLATFORM_WIN32 cmake flag on Windows, otherwise use the sdl2 dependency. MSVC build PR is here: FNA-XNA/FAudio#333 , followup PR to fix alignment is here: FNA-XNA/FAudio#334 , MSYS2 package is here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-faudio/PKGBUILD . Signed-off-by: Rafael Kitover <[email protected]>
rkitover
added a commit
to rkitover/vcpkg
that referenced
this pull request
Mar 10, 2024
Add new port FAudio, an "accuracy-focused XAudio reimplementation for open platforms". Use the PLATFORM_WIN32 cmake flag on Windows, otherwise use the sdl2 dependency. MSVC build PR is here: FNA-XNA/FAudio#333 , followup PR to fix alignment is here: FNA-XNA/FAudio#334 , MSYS2 package is here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-faudio/PKGBUILD . Signed-off-by: Rafael Kitover <[email protected]>
rkitover
added a commit
to rkitover/vcpkg
that referenced
this pull request
Mar 10, 2024
Add new port FAudio, an "accuracy-focused XAudio reimplementation for open platforms". Use the PLATFORM_WIN32 cmake flag on Windows, otherwise use the sdl2 dependency. MSVC build PR is here: FNA-XNA/FAudio#333 , followup PR to fix alignment is here: FNA-XNA/FAudio#334 , and another followup for the SDL2 dependency: FNA-XNA/FAudio#335 , the MSYS2 package is here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-faudio/PKGBUILD . Signed-off-by: Rafael Kitover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on 81d5a24 (build: fix building with MSVC,
2024-03-07).
Fix the missing trailing _ in attribute for
__attribute((aligned(x))).