Prefix CMake options with FLAMEGPU_ + use mark_as_advanced #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
force-pushed
the
cmake-option-prefixing
branch
4 times, most recently
from
64997bb to
6db1475
Compare
Robadob
reviewed
Nov 29, 2022
ptheywood
force-pushed
the
cmake-option-prefixing
branch
from
ccc414c to
7928417
Compare
Robadob
reviewed
Dec 1, 2022
…ovments + Prefixes CMake option and cache variables with FLAMEGPU_VISUALISER + Prefix CMake macros and functions with flamegpu_visualiser_ and use lower snake case + Remove unneeded reference to SEATBELTS from CMake + Mark many CMake variables as advanced to simplify the CMake GUI + Fix cmake_minimimum_requires statemeents and add a policy_max of 3.25 + This requied a fix for a CMake 3.21 policy + Use more-modern CMake C++/CUDA standard setting + Modernise/simplify GLM CMake and use PUBLIC/PRIVATE target_link_libraries + Provide list of DLLs via flamegpu_visualiser_get_runtime_depenencies to simplify code in FLAMEGPU/FLAMEGPU2
ptheywood
force-pushed
the
cmake-option-prefixing
branch
from
7928417 to
b4b3c3d
Compare
|
Just pushed a minor fix / improvement to the cuda architectures setting logic, so that if you specify via the CLI the GUI becomes aware of the value (I'd reduced some duplication at one point, but not correctly changed the logic for all branches to work). Otherwise once CI is happy I'll merge this so I can update the hash in the main repo PR too so that can then rerun CI and should be mergable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixes CMake options / cache variables with
FLAMEGPU_and cleans up the CMake UI viamark_as_advanced.Switches from CUDA_ARCH to the native
CMAKE_CUDA_ARCHITECTURESRequired by FLAMEGPU/FLAMEGPU2#991