Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling omp tests #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiling omp tests #154

wants to merge 1 commit into from

Conversation

jtravs
Copy link

@jtravs jtravs commented Sep 26, 2018

No description provided.

@jtravs jtravs mentioned this pull request Sep 27, 2018
Merged
@ZedThree
Copy link

This also needs target_link_libraries (${fftw3_lib}_omp OpenMP::OpenMP_C) so that the OpenMP dependency is propagated to targets.

stevengj
stevengj reviewed Feb 27, 2020
View reviewed changes
CMakeLists.txt
if (ENABLE_OPENMP)
target_link_libraries (bench ${fftw3_lib}_omp)
else ()
target_link_libraries (bench ${fftw3_lib})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this else clause is needed, since ${fftw3_lib} should have already been added by the preceding if/else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtravs @ZedThree @stevengj