quote CMDLINE env var exe name if needed, fix memory leak in expandEnvVars, memory corruption in set command #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems correct. I want to do more tests on this, especially wrt separators other than blanks and what MSW 98 SE does for those. |
boeckmann
changed the title
adapt to messed up indentation
|
I haven't had a chance to test, but once it gets reviewed (assuming nothing comes up), it should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review line 218. I am not 100% sure if the +3 in the allocation is correct. This should leave space for two quotation marks and the terminating zero. But previously it was +2 without adding the space for the quotation marks. I do not know where the +2 came from. I think +1 for the terminating zero would have been enough.
Referencing #97