Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update FROM base from default to blank #326

Open
wants to merge 3 commits into
base: source
Choose a base branch
from
Open

Conversation

shnizzedy
Copy link
Member

Related to

Related to FCP-INDI/C-PAC#2148 by @shnizzedy

Related to

FCP-INDI/C-PAC#2145 (comment) by @suxpert

I regard the config file as terrified since it:
[…]

  • was too complex since there are too many things to write, but I did not find the logic of all those stuffs;

Related to

FCP-INDI/C-PAC#2145 (comment) by @tamsinrogers

If FROM is not specified, the pipeline will be based on the blank pipeline.

Related to

FCP-INDI/C-PAC#1801 by @shnizzedy

  • Updates the base for minified configs from default to blank.

Description

Screenshots

changes

before this PR with this PR
"If FROM is not specified, the pipeline will be based on the default pipeline." "If FROM is not specified, the pipeline will be based on the blank pipeline."
"Pipeline Configuration YAML: https://github.com/FCP-INDI/C-PAC/blob/v1.8.7/CPAC/resources/configs/pipeline_config_default.yml"
(link to https://github.com/FCP-INDI/C-PAC/blob/v1.8.7/CPAC/resources/configs/pipeline_config_default.yml)
Pipeline Configuration YAML
(link to https://fcp-indi.github.io/docs/v1.8.7/user/pipelines/default)

additions

Each preconfig automatically gets a page like this one for the blank preconfig:

top part of blank preconfig documentation
bottom part of blank preconfig documentation

Checklist

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy requested a review from a team September 6, 2024 14:48
@shnizzedy shnizzedy self-assigned this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant