Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Launch runs for regression tests from CI (2/2) #2001

Merged
merged 543 commits into from
Oct 12, 2023

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Oct 2, 2023

Related to

Related to #1904 by @amygutierrez

Part of a series toward automating regression testing

  1. 👷 Launch runs for regression tests from CI (1/2) childmindresearch/slurm_testing#1
  2. 📦️ Restore WORKDIR to final-stage Dockerfiles #1999 + this PR

Description

Once childmindresearch/slurm_testing#1 is merged, these changes will allow this repo to trigger remote testing runs

  • on pushes with "[run reg-suite]" in the commit message
  • on pull requests to develop when the PRs are
    • opened
    • marked ready-for-review
    • reopened

Technical details

Tests

I've been running all these changes in CI configuration on my forks of these repos to test.

Screenshots

When runs fail, the checks should show red like https://github.com/FCP-INDI/C-PAC/assets/5974438/c2613976-a1d7-4237-a8c1-2015fe1d674c

In any case, logs should be available on GitHub like this.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Collaborator

@sgiavasis sgiavasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@shnizzedy shnizzedy marked this pull request as draft October 3, 2023 21:37
@shnizzedy shnizzedy marked this pull request as ready for review October 3, 2023 21:37
@shnizzedy
Copy link
Member Author

image = messing with deployment triggers

@shnizzedy shnizzedy marked this pull request as draft October 3, 2023 22:34
@shnizzedy shnizzedy marked this pull request as ready for review October 3, 2023 22:34
@shnizzedy shnizzedy temporarily deployed to ACCESS October 3, 2023 23:30 — with GitHub Actions Inactive
@shnizzedy shnizzedy marked this pull request as draft October 4, 2023 02:16
@shnizzedy shnizzedy marked this pull request as ready for review October 4, 2023 02:16
@shnizzedy shnizzedy marked this pull request as draft October 4, 2023 02:30
@shnizzedy shnizzedy force-pushed the regression/after-runs branch from 80f5060 to 2913c38 Compare October 4, 2023 02:31
@shnizzedy shnizzedy marked this pull request as ready for review October 4, 2023 02:31
@shnizzedy shnizzedy marked this pull request as draft October 4, 2023 03:30
@shnizzedy shnizzedy marked this pull request as ready for review October 4, 2023 03:30
@shnizzedy shnizzedy temporarily deployed to ACCESS October 4, 2023 03:56 — with GitHub Actions Inactive
@sgiavasis sgiavasis merged commit 34073b9 into FCP-INDI:develop Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants