-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
70 support for rsm plots #78
Conversation
5c283f5
to
89e471f
Compare
89e471f
to
a2a1ef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just fix the q_norm thing.
Co-authored-by: Hampus Näsström <[email protected]>
@hampusnasstrom Thanks for the review! I have added your suggestions and also did some ruff formatting mostly on the code I touched. Please have a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it now and everything works. I have some suggestions on the plots but I will write a separate issue for this. For now I will go ahead and merge this.
No description provided.