Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write archive.data.result section with hdf5 ref #116

Open
wants to merge 33 commits into
base: write-nexus-section
Choose a base branch
from

Conversation

RubelMozumder
Copy link
Contributor

PR #111 is handled here.

@RubelMozumder RubelMozumder changed the base branch from main to write-nexus-section August 29, 2024 11:42
@RubelMozumder RubelMozumder changed the base branch from write-nexus-section to main August 29, 2024 12:21
@RubelMozumder RubelMozumder changed the base branch from main to write-nexus-section August 29, 2024 12:21
@RubelMozumder RubelMozumder changed the base branch from write-nexus-section to main August 29, 2024 12:23
@ka-sarthak
Copy link
Collaborator

@RubelMozumder we should base this PR on write-nexus-section not main. Probably the pipeline will not be triggered in this case, which can be resolved by changing github action config.

@ka-sarthak ka-sarthak changed the base branch from main to write-nexus-section August 29, 2024 13:20
@RubelMozumder RubelMozumder force-pushed the write-nexus-section-hdf5-ref branch from f5a9abf to c01da98 Compare August 29, 2024 14:18
@RubelMozumder
Copy link
Contributor Author

@RubelMozumder we should base this PR on write-nexus-section not main. Probably the pipeline will not be triggered in this case, which can be resolved by changing github action config.

Yeah, I know. I just updated to compare the test between github pipeline and local one.

aalbino2 and others added 15 commits November 25, 2024 11:42
Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Hampus Näsström <[email protected]>
* Implement write nexus section based on the populated nomad archive

* app def missing.

* mapping nomad_measurement.

* All concept are connected, creates nexus file and subsection.

* adding links in hdf5 file.

* Remove the nxs file.

* back to the previous design.

* Include pynxtools plugins in nomad.yaml and extend dependencies including pynxtools ans pnxtools-xrd.

* PR review correction.

* Remove the entry_type overwtitten.

* Remove comments.

* Replace __str__ function.

* RUFF

* Update pyproject.toml

Co-authored-by: Sarthak Kapoor <[email protected]>

* Update src/nomad_measurements/xrd/schema.py

Co-authored-by: Sarthak Kapoor <[email protected]>

* Update src/nomad_measurements/xrd/nx.py

* Replace Try-block.

---------

Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Sarthak Kapoor <[email protected]>
@ka-sarthak ka-sarthak force-pushed the write-nexus-section-hdf5-ref branch from a61f467 to f0a8606 Compare November 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants