Scan from tamash #304
Open
Scan from tamash #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here...
RubelMozumder
added a commit
that referenced
this pull request
Nov 27, 2024
* space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <[email protected]>
RubelMozumder
added a commit
that referenced
this pull request
Nov 29, 2024
* space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <[email protected]>
RubelMozumder
added a commit
that referenced
this pull request
Dec 5, 2024
* space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <[email protected]> Rename lockin_current_flip_number to loockin_current_flip_sign. add NXidentifier in NXsensor_scan. Delete unnecessary file. Revert "Delete unnecessary file." This reverts commit 8c6b03c. Preparation for example in nomad. Corrected typo in heterodyne word Update NXlockin.yaml Minor fix.
RubelMozumder
added a commit
that referenced
this pull request
Dec 5, 2024
* space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <[email protected]> Rename lockin_current_flip_number to loockin_current_flip_sign. add NXidentifier in NXsensor_scan. Delete unnecessary file. Revert "Delete unnecessary file." This reverts commit 8c6b03c. Preparation for example in nomad. Corrected typo in heterodyne word Update NXlockin.yaml Minor fix.
RubelMozumder
added a commit
that referenced
this pull request
Dec 6, 2024
* First final draft for application definiton NXsts, NXstm, NXaf, NXspm and base classes NXlockin, NXbias_spectroscopy, cantilever_spm, NXbias_sweep, NXpiezo_config_spm, NXpositioner_spm, NXscan_control, NXpiezoelectric_material and NXrcs. Finish review comments from Lev. * Remove SPM folder. * Remove SPM folder. Revert "Remove SPM folder." This reverts commit 3aeb39e. PR review from Lukas! Delete unnecessary files. Revert "Delete unnecessary files." This reverts commit 317a367. Include the default key attribute on entry and include NXhistory under the NXsample for verbose purpose. * Review from Tamash (#303) * space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <[email protected]> Rename lockin_current_flip_number to loockin_current_flip_sign. add NXidentifier in NXsensor_scan. Delete unnecessary file. Revert "Delete unnecessary file." This reverts commit 8c6b03c. Preparation for example in nomad. Corrected typo in heterodyne word Update NXlockin.yaml Minor fix. * Remove redundant files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.