Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop 484 #513

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Develop 484 #513

merged 2 commits into from
Dec 2, 2023

Conversation

beckpaul
Copy link
Collaborator

@beckpaul beckpaul commented Dec 2, 2023

Addresses point 1 of #484
Escaping - clears the error from browser
Includes some trimming of trailing white-space

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82aeb42) 46.26% compared to head (60b3745) 46.26%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #513   +/-   ##
========================================
  Coverage    46.26%   46.26%           
========================================
  Files           56       56           
  Lines         1204     1204           
  Branches       131      131           
========================================
  Hits           557      557           
  Misses         633      633           
  Partials        14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps
Copy link
Collaborator

fcaps commented Dec 2, 2023

looks like data-remote, data-minlength-error etc. are not used anymore, maybe they got refactored at some point.

@fcaps fcaps merged commit d231e86 into FAForever:develop Dec 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants