Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable eslint #499

Merged
merged 2 commits into from
Nov 28, 2023
Merged

enable eslint #499

merged 2 commits into from
Nov 28, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 28, 2023

to enable the linter i had to fix some of the files + actually fixing bugs.

short overview:

  • leaderboard needed some function bound to the window
  • account/report was missing jquery + it's now bundled
  • highcharst are now bundled + remove unused option

…eport is still broken) + exposing function into window for leaderboard
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@9d5de76). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #499   +/-   ##
==========================================
  Coverage           ?   41.89%           
==========================================
  Files              ?       47           
  Lines              ?     1117           
  Branches           ?      129           
==========================================
  Hits               ?      468           
  Misses             ?      635           
  Partials           ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps fcaps requested a review from Sheikah45 November 28, 2023 01:38
This was referenced Nov 28, 2023
@fcaps fcaps merged commit beaa488 into FAForever:develop Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant