Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint #498

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Eslint #498

merged 1 commit into from
Nov 27, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 26, 2023

only added eslint without enforcing it.
this includes changes from #497

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@373b885). Click here to learn what that means.

❗ Current head af21c56 differs from pull request most recent head c8caa78. Consider uploading reports for the commit c8caa78 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #498   +/-   ##
==========================================
  Coverage           ?   41.93%           
==========================================
  Files              ?       47           
  Lines              ?     1116           
  Branches           ?      128           
==========================================
  Hits               ?      468           
  Misses             ?      634           
  Partials           ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps fcaps force-pushed the feature/webpack_eslint branch from af21c56 to c8caa78 Compare November 27, 2023 13:56
@fcaps fcaps marked this pull request as ready for review November 27, 2023 13:57
@fcaps fcaps requested a review from Sheikah45 November 27, 2023 14:04
@fcaps fcaps merged commit 9d5de76 into FAForever:develop Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants