Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed /client route, it was not working since a long time #469

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 17, 2023

it was also not working before my change to the github-downlaod stuff.
also.. don't get the use of a download link redirected via the server (maybe tracking?), but hey, who knows

Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding outdated a-element in index.pug should be removed too

@fcaps fcaps force-pushed the bugfix/remove-unused-link branch from 4e7309e to 0e69045 Compare November 18, 2023 20:12
@fcaps
Copy link
Collaborator Author

fcaps commented Nov 18, 2023

The corresponding outdated a-element in index.pug should be removed too

good catch, was not aware of it, maybe bc. it was already commented out xD

@fcaps fcaps changed the title remove this route, it was not working since a long time removed /client route, it was not working since a long time Nov 18, 2023
@fcaps fcaps requested a review from Brutus5000 November 18, 2023 20:15
express.js Outdated Show resolved Hide resolved
@fcaps fcaps force-pushed the bugfix/remove-unused-link branch from 0e69045 to 4d633e6 Compare November 18, 2023 21:03
@fcaps fcaps requested a review from Sheikah45 November 18, 2023 21:03
@Sheikah45 Sheikah45 merged commit f94dbfd into FAForever:develop Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants