linter fixes

src/backend/routes/views/account/get/connectSteam.js

@@ -12,7 +12,14 @@ exports = module.exports = function (req, res) {
         headers: { Authorization: 'Bearer ' + req.services.userService.getUser()?.oAuthPassport.token },
         form: { callbackUrl: req.protocol + '://' + req.get('host') + '/account/link?done' }
     }, function (err, res, body) {
-    // Must not be valid, check to see if errors, otherwise return generic error.
+        if (err) {
+            flash.class = 'alert-danger'
+            flash.messages = [{ msg: 'Your steam account was not successfully linked! Please verify you logged into the website correctly.' }]
+            flash.type = 'Error!'
+
+            return overallRes.render('account/linkSteam', { flash })
+        }
+        // Must not be valid, check to see if errors, otherwise return generic error.
         try {
             body = JSON.parse(body)
 

src/backend/routes/views/account/get/linkGog.js

@@ -31,7 +31,7 @@ exports = module.exports = function (req, res) {
         form: {}
     }, function (err, res, body) {
         locals.gogToken = 'unable to obtain token'
-        if (res === undefined || res.statusCode !== 200) {
+        if (err || res.statusCode !== 200) {
             flash = {}
             error.parseApiErrors(body, flash)
             return overallRes.render('account/linkGog', { flash })

src/backend/routes/views/account/get/requestPasswordReset.js

@@ -20,6 +20,7 @@ exports = module.exports = async function (req, res) {
             recaptchaSiteKey: appConfig.recaptchaKey
         })
     }).catch(error => {
+        console.error(error.toString())
         res.render('account/requestPasswordReset', {
             section: 'account',
             flash: {

src/backend/routes/views/account/get/resync.js

@@ -17,7 +17,7 @@ exports = module.exports = function (req, res) {
         url: process.env.API_URL + '/users/resyncAccount',
         headers: { Authorization: 'Bearer ' + req.services.userService.getUser()?.oAuthPassport.token }
     }, function (err, res, body) {
-        if (res.statusCode !== 200) {
+        if (err || res.statusCode !== 200) {
             error.parseApiErrors(body, flash)
         } else {
         // Successfully account resync

src/backend/routes/views/account/post/activate.js

@@ -36,7 +36,7 @@ exports = module.exports = function (req, res) {
             url: process.env.API_URL + '/users/activate',
             form: { password, token }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/activate', { flash })
             }

src/backend/routes/views/account/post/changeEmail.js

@@ -36,7 +36,7 @@ exports = module.exports = function (req, res) {
             headers: { Authorization: `Bearer ${req.services.userService.getUser()?.oAuthPassport.token}` },
             form: { newEmail: email, currentPassword: password }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/changeEmail', { flash })
             }

src/backend/routes/views/account/post/changePassword.js

@@ -42,7 +42,7 @@ exports = module.exports = function (req, res) {
             headers: { Authorization: 'Bearer ' + req.services.userService.getUser()?.oAuthPassport.token },
             form: { name: username, currentPassword: oldPassword, newPassword }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/changePassword', { flash })
             }

src/backend/routes/views/account/post/changeUsername.js

@@ -34,7 +34,7 @@ exports = module.exports = function (req, res) {
             headers: { Authorization: 'Bearer ' + req.services.userService.getUser()?.oAuthPassport.token },
             form: { newUsername: username }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/changeUsername', { flash })
             }

src/backend/routes/views/account/post/confirmPasswordReset.js

@@ -36,7 +36,7 @@ exports = module.exports = function (req, res) {
             url: process.env.API_URL + '/users/performPasswordReset',
             form: { newPassword, token }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/confirmPasswordReset', { flash })
             }

src/backend/routes/views/account/post/linkGog.js

@@ -34,7 +34,7 @@ exports = module.exports = function (req, res) {
             headers: { Authorization: 'Bearer ' + req.services.userService.getUser()?.oAuthPassport.token },
             form: { gogUsername }
         }, function (err, res, body) {
-            if (res !== undefined && res.statusCode === 200) {
+            if (!err && res.statusCode === 200) {
                 flash.class = 'alert-success'
                 flash.messages = [{ msg: 'Your accounts were linked successfully.' }]
                 flash.type = 'Success!'
@@ -53,7 +53,7 @@ exports = module.exports = function (req, res) {
                     form: {}
                 }, function (err, res, body) {
                     locals.gogToken = 'unable to obtain token'
-                    if (res === undefined || res.statusCode !== 200) {
+                    if (err || res.statusCode !== 200) {
                         flash = {}
                         error.parseApiErrors(body, flash)
                         return overallRes.render('account/linkGog', { flash })

src/backend/routes/views/account/post/register.js

@@ -40,7 +40,7 @@ exports = module.exports = function (req, res) {
             let resp
             const errorMessages = []
 
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 try {
                     resp = JSON.parse(body)
                 } catch (e) {

src/backend/routes/views/account/post/requestPasswordReset.js

@@ -32,7 +32,7 @@ exports = module.exports = function (req, res) {
             url: process.env.API_URL + '/users/requestPasswordReset',
             form: { identifier, recaptchaResponse }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 error.parseApiErrors(body, flash)
                 return overallRes.render('account/requestPasswordReset', {
                     flash,

src/backend/routes/views/clans/get/accept_invite.js

@@ -67,13 +67,14 @@ exports = module.exports = function (req, res) {
             locals.clanName = clan.data.attributes.name
             locals.clanLeaderName = '<unknown>'
 
-            for (k in clan.included) {
+            for (const k in clan.included) {
+                let player = null
                 switch (clan.included[k].type) {
                 case 'player':
-                    const player = clan.included[k]
+                    player = clan.included[k]
 
                     // Getting the leader name
-                    if (player.id == clan.data.relationships.leader.data.id) {
+                    if (player.id === clan.data.relationships.leader.data.id) {
                         locals.clanLeaderName = player.attributes.login
                     }
 

src/backend/routes/views/clans/get/create.js

@@ -15,6 +15,10 @@ exports = module.exports = function (req, res) {
             }
         },
         function (err, childRes, body) {
+            if (err) {
+                return res.redirect('/clans/manage')
+            }
+
             const clanInfo = JSON.parse(body)
             if (clanInfo.clan != null) {
                 res.redirect('/clans/manage')
@@ -38,7 +42,7 @@ exports = module.exports = function (req, res) {
                 } catch (e) {
                     console.error('Parsing error while trying to decode a flash error: ' + text)
                     console.error(e)
-                    flasg = [{ msg: 'Unknown error' }]
+                    flash = [{ msg: 'Unknown error' }]
                 }
             }
 

src/backend/routes/views/clans/get/manage.js

@@ -60,7 +60,7 @@ exports = module.exports = function (req, res) {
                 return res.redirect('/clans?flash=' + data)
             }
 
-            if (clan.data.relationships.leader.data.id != req.user.data.id) {
+            if (clan.data.relationships.leader.data.id !== req.user.data.id) {
                 // Not the leader! Shouldn't be able to manage stuff
                 res.redirect(`/clans/${req.user.data.attributes.clan.tag}?member=true`)
                 return
@@ -75,23 +75,26 @@ exports = module.exports = function (req, res) {
             locals.clan_link = process.env.HOST + '/clans/see?id=' + clan.data.id
 
             const members = {}
+            let player = null
+            let membership = null
+            let member = null
 
-            for (k in clan.included) {
+            for (const k in clan.included) {
                 switch (clan.included[k].type) {
                 case 'player':
-                    const player = clan.included[k]
+                    player = clan.included[k]
                     if (!members[player.id]) members[player.id] = {}
                     members[player.id].id = player.id
                     members[player.id].name = player.attributes.login
 
-                    if (clan.data.relationships.founder.data.id == player.id) {
+                    if (clan.data.relationships.founder.data.id === player.id) {
                         locals.founder_name = player.attributes.login
                     }
                     break
 
                 case 'clanMembership':
-                    const membership = clan.included[k]
-                    const member = membership.relationships.player.data
+                    membership = clan.included[k]
+                    member = membership.relationships.player.data
                     if (!members[member.id]) members[member.id] = {}
                     members[member.id].id = member.id
                     members[member.id].membershipId = membership.id
@@ -102,7 +105,7 @@ exports = module.exports = function (req, res) {
 
             locals.clan_members = members
 
-            if (req.originalUrl == '/clan_created') {
+            if (req.originalUrl === '/clan_created') {
                 flash = {}
                 flash.class = 'alert-success'
                 flash.messages = [{ msg: 'You have successfully created your clan' }]

src/backend/routes/views/clans/post/create.js

@@ -2,18 +2,6 @@ const flash = {}
 const request = require('request')
 const { check, validationResult } = require('express-validator')
 
-function promiseRequest (url) {
-    return new Promise(function (resolve, reject) {
-        request(url, function (error, res, body) {
-            if (!error && res.statusCode < 300) {
-                resolve(body)
-            } else {
-                reject(error)
-            }
-        })
-    })
-}
-
 exports = module.exports = async function (req, res) {
     const locals = res.locals
 
@@ -43,24 +31,6 @@ exports = module.exports = async function (req, res) {
         const clanName = req.body.clan_name
         const clanTag = req.body.clan_tag
         const clanDescription = req.body.clan_description
-        const userId = req.body.user_id
-
-        // Let's check first that the name or tag are not taken
-        const clanFetchRoute = process.env.API_URL + '/data/clan?filter=name=="' + clanName + '",tag=="' + clanTag + '"'
-        let exists = true
-        try {
-            const httpData = await promiseRequest(clanFetchRoute)
-            exists = JSON.parse(httpData).data.length > 0
-        } catch (e) {
-            flash.class = 'alert-danger'
-            flash.messages = [{ msg: 'Error while creating the clan ' + e }]
-            flash.type = 'Error!'
-
-            const buff = Buffer.from(JSON.stringify(flash))
-            const data = buff.toString('base64')
-
-            return overallRes.redirect('create?flash=' + data + '&clan_name=' + clanName + '&clan_tag=' + clanTag + '&clan_description=' + clanDescription + '')
-        }
 
         const queryUrl =
       process.env.API_URL +
@@ -77,10 +47,9 @@ exports = module.exports = async function (req, res) {
                 Authorization: 'Bearer ' + req.user.data.attributes.token
             }
         }, function (err, res, body) {
-            let resp
             const errorMessages = []
 
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 let msg = 'Error while creating the clan'
                 try {
                     msg += ': ' + JSON.stringify(JSON.parse(res.body).errors[0].detail)
@@ -105,6 +74,11 @@ exports = module.exports = async function (req, res) {
                 }
             },
             function (err, res, body) {
+                if (err) {
+                    console.error('There was an error updating a session after a clan creation')
+
+                    return
+                }
                 try {
                     const user = JSON.parse(body)
                     user.data.attributes.token = req.user.data.attributes.token

src/backend/routes/views/clans/post/destroy.js

@@ -2,18 +2,6 @@ let flash = {}
 const request = require('request')
 const { check, validationResult } = require('express-validator')
 
-function promiseRequest (url) {
-    return new Promise(function (resolve, reject) {
-        request(url, function (error, res, body) {
-            if (!error && res.statusCode < 300) {
-                resolve(body)
-            } else {
-                reject(error)
-            }
-        })
-    })
-}
-
 exports = module.exports = async function (req, res) {
     const locals = res.locals
 
@@ -51,10 +39,9 @@ exports = module.exports = async function (req, res) {
                 Authorization: 'Bearer ' + req.user.data.attributes.token
             }
         }, function (err, res, body) {
-            let resp
             const errorMessages = []
 
-            if (res.statusCode != 204) {
+            if (err || res.statusCode !== 204) {
                 let msg = 'Error while destroying the clan'
                 try {
                     msg += ': ' + JSON.stringify(JSON.parse(res.body).errors[0].detail)
@@ -87,6 +74,11 @@ exports = module.exports = async function (req, res) {
             },
 
             function (err, res, body) {
+                if (err) {
+                    console.error('There was an error updating a session after a clan destruction')
+
+                    return
+                }
                 try {
                     const user = JSON.parse(body)
                     user.data.id = user.data.attributes.userId

src/backend/routes/views/clans/post/invite.js

@@ -60,13 +60,11 @@ exports = module.exports = async function (req, res) {
         // Let's check first that the player exists
         const fetchRoute = process.env.API_URL + '/data/player?filter=login=="' + userName + '"&fields[player]='
 
-        let exists = true
         let playerData = null
         let playerId = null
         try {
             const httpData = await promiseRequest(fetchRoute)
             playerData = JSON.parse(httpData).data
-            exists = playerData.length > 0
             playerId = playerData[0].id
         } catch (e) {
             flash.class = 'alert-danger'
@@ -93,7 +91,7 @@ exports = module.exports = async function (req, res) {
                 Authorization: 'Bearer ' + req.user.data.attributes.token
             }
         }, function (err, res, body) {
-            if (res.statusCode !== 200) {
+            if (err || res.statusCode !== 200) {
                 const errorMessages = []
                 let msg = 'Error while generating the invite link'
                 try {

src/backend/routes/views/clans/post/join.js

@@ -22,7 +22,6 @@ exports = module.exports = function (req, res) {
     }
 
     const token = req.query.token
-    const clanId = req.query.clan_id
 
     request.post(
         {
@@ -32,8 +31,14 @@ exports = module.exports = function (req, res) {
             }
         },
         function (err, childRes, body) {
+            if (err) {
+                console.error('There was an error at join')
+
+                return
+            }
+
             let flashData
-            if (childRes.statusCode == 200 || childRes.statusCode == 201) {
+            if (childRes.statusCode === 200 || childRes.statusCode === 201) {
                 flash.class = 'alert-success'
                 flash.messages = [
                     { msg: 'Welcome to your new clan!' }
@@ -51,6 +56,11 @@ exports = module.exports = function (req, res) {
                 },
 
                 function (err, res, body) {
+                    if (err) {
+                        console.error('There was an error updating a session after an user left a clan')
+
+                        return
+                    }
                     try {
                         const user = JSON.parse(body)
                         user.data.id = user.data.attributes.userId