Skip to content

Commit

Permalink
Issues:
Browse files Browse the repository at this point in the history
Fixes #96

Problem: Unable to pass traffic through VE deployed in guest tenant

Analysis: This deployment of a VE inside the tenant has never been tested.  The code was attempting to reference a nested dictionary key that is not populated in 'global routed mode'.  The necessary value is contained in the parent dictionary.

Tests: Standard "overcloud" deployment. Run traffic test from lbaasv2-driver repo. (We're working on backporting tests to lbaasv1).
  • Loading branch information
Matthew Greene committed May 6, 2016
1 parent 39ad427 commit 89c0205
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions agent/f5/oslbaasv1agent/drivers/bigip/vips.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def assure_bigip_create_vip(self, bigip, service, traffic_group):
just_added_vip:
self._update_bigip_vip(bigip, service)
if self.l3_binding:
self.l3_binding.bind_address(subnet_id=vip['subnet']['id'],
self.l3_binding.bind_address(subnet_id=vip['subnet_id'],
ip_address=ip_address)

def assure_bigip_delete_vip(self, bigip, service):
Expand All @@ -98,7 +98,7 @@ def assure_bigip_delete_vip(self, bigip, service):
vip['id'],
folder=vip['tenant_id'])
if self.l3_binding:
self.l3_binding.unbind_address(subnet_id=vip['subnet']['id'],
self.l3_binding.unbind_address(subnet_id=vip['subnet_id'],
ip_address=vip['address'])

def _create_bigip_vip(self, bigip, service, vip_info):
Expand Down

0 comments on commit 89c0205

Please sign in to comment.