Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 64-bit bitmaps, fix #58 #106

Merged
merged 26 commits into from
Aug 24, 2024
Merged

Add support for 64-bit bitmaps, fix #58 #106

merged 26 commits into from
Aug 24, 2024

Conversation

Ezibenroc
Copy link
Owner

No description provided.

@Ezibenroc
Copy link
Owner Author

Current status:

  • All the features implemented in roaring64.h have been implemented in pyroaring.
  • Compared to 32 bit version, there misses some minor features (e.g. shift operation), but nothing preventing a release IMO.
  • Tests have been implemented, mostly a copy-paste from the 32 bit version, with some minor changes. Note that I did not change yet the range of values covered by the tests, this needs to be done. Tests from the RangeTest are still failing sometimes, due to subtle bugs only appearing with specific values.

@Ezibenroc
Copy link
Owner Author

Next steps would be to unify the tests: testing both 32 and 64 bits classes with the same code (with only minor adaptations to handle the specificities of each class). Work in progress.

@Ezibenroc Ezibenroc marked this pull request as ready for review August 24, 2024 12:54
@Ezibenroc Ezibenroc changed the title [WIP] Add support for 64-bit bitmaps, fix #58 Add support for 64-bit bitmaps, fix #58 Aug 24, 2024
@Ezibenroc Ezibenroc merged commit b54769b into master Aug 24, 2024
30 checks passed
@Ezibenroc Ezibenroc deleted the roaring64 branch August 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants