Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local time zone fix, all last updated times #34

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Nov 3, 2024

📌 References

  • Issue: Closes #?

📝 Implementation

  • Fix last updated time for all pages
  • Convert to local time
  • Fix server timezone to local time issue.
  • Fix IAP infinite loop

📹 Screenshots/Screen capture

Screenshot 2024-11-03 at 11 07 30 PM Screenshot 2024-11-03 at 11 07 53 PM Screenshot 2024-11-03 at 11 08 00 PM Screenshot 2024-11-03 at 11 08 07 PM

🔥 Notes to the tester

@9sneha-n 9sneha-n marked this pull request as ready for review November 7, 2024 06:03
Base automatically changed from fix/oct-misc-bug-fixes to development November 7, 2024 09:56
@@ -48,8 +49,17 @@ export function mapD2EventsToIncidentManagementTeam(
[]
);

const sortedByUpdatedDates = d2Events.sort(function (a, b) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be in the other way arround

@9sneha-n 9sneha-n requested a review from anagperal November 8, 2024 17:17
Copy link
Contributor

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @9sneha-n ! 🎉

@bhavananarayanan bhavananarayanan merged commit 0a809cf into development Nov 11, 2024
1 check passed
@bhavananarayanan bhavananarayanan deleted the fix/local-timezone branch November 11, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants