Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default app namespace #55

Merged
merged 1 commit into from
Jul 1, 2024
Merged

use default app namespace #55

merged 1 commit into from
Jul 1, 2024

Conversation

deeonwuli
Copy link
Contributor

📌 References

📝 Implementation

  • Update i18n types
  • Set default namespace in app-context.ts

🎨 Screenshots

Screenshot 2024-06-25 at 20 14 42

🔥 Notes to the tester

I added a translation for Loading... to test

#8694ubx3x

@deeonwuli deeonwuli requested review from MiquelAdell and eperedo June 25, 2024 19:15
eperedo
eperedo approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, thanks @deeonwuli

@MiquelAdell MiquelAdell merged commit b6005c6 into development Jul 1, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the fix/translation-namespace branch July 1, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eperedo eperedo eperedo approved these changes

@MiquelAdell MiquelAdell Awaiting requested review from MiquelAdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deeonwuli @eperedo @MiquelAdell