Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add Music Player component. #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature: Add Music Player component. #63

wants to merge 3 commits into from

Conversation

jmckinnell
Copy link
Member

  • Add a simple HTML5 audio tag based player intended to be used with background music.
  • Features mobile touch/click based activation.

What kind of change does this PR introduce? (check at least one)

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Code style update
  • Refactor (refactoring or adding test which isn't a fix or add a feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Did you test your solution?

  • I lightly tested it in one browser
  • I deeply tested it in several browsers
  • I wrote tests around it (unit tests, integration tests, E2E tests)

@jmckinnell jmckinnell linked an issue Apr 18, 2022 that may be closed by this pull request
[Component] - Audio Player #19
Open
@jmckinnell jmckinnell requested a review from alemesa April 25, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemesa alemesa Awaiting requested review from alemesa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] - Audio Player
1 participant
@jmckinnell