Update dependencies

__tests__/core/config.test.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const path = require('path');
-const cosmiconfig = require('cosmiconfig');
+const { cosmiconfig } = require('cosmiconfig');
 const Config = require('../../src/core/config/config');
 const ConfigFileValidationError = require('../../src/core/errors/exceptions/config-file-validation-error');
 

__tests__/core/engine.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const cosmiconfig = require('cosmiconfig');
+const { cosmiconfig } = require('cosmiconfig');
 
 const AdviserRule = require('../../src/core/external/rule');
 

package.json

@@ -23,26 +23,26 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@commitlint/cli": "8.1.0",
-    "@commitlint/config-conventional": "7.5.0",
-    "audit-ci": "1.3.1",
-    "babel-eslint": "10.0.1",
-    "envinfo": "7.0.0",
-    "eslint": "5.16.0",
-    "eslint-config-jam3": "2.0.0",
-    "eslint-config-prettier": "4.3.0",
-    "eslint-config-standard": "12.0.0",
-    "eslint-plugin-import": "2.18.2",
-    "eslint-plugin-jest": "22.2.2",
-    "eslint-plugin-node": "8.0.1",
-    "eslint-plugin-prettier": "3.0.1",
-    "eslint-plugin-promise": "4.0.1",
-    "eslint-plugin-standard": "4.0.0",
-    "husky": "2.1.0",
-    "jest": "24.7.1",
-    "lint-staged": "8.1.5",
-    "prettier": "1.16.4",
-    "standard-version": "7.0.1"
+    "@commitlint/cli": "12.1.4",
+    "@commitlint/config-conventional": "12.1.4",
+    "audit-ci": "4.1.0",
+    "babel-eslint": "10.1.0",
+    "envinfo": "7.8.1",
+    "eslint": "7.30.0",
+    "eslint-config-jam3": "2.0.1",
+    "eslint-config-prettier": "8.3.0",
+    "eslint-config-standard": "16.0.3",
+    "eslint-plugin-import": "2.23.4",
+    "eslint-plugin-jest": "24.3.6",
+    "eslint-plugin-node": "11.1.0",
+    "eslint-plugin-prettier": "3.4.0",
+    "eslint-plugin-promise": "5.1.0",
+    "eslint-plugin-standard": "5.0.0",
+    "husky": "7.0.1",
+    "jest": "27.0.6",
+    "lint-staged": "11.0.0",
+    "prettier": "2.3.2",
+    "standard-version": "9.3.0"
   },
   "jest": {
     "collectCoverage": true,
@@ -71,19 +71,19 @@
     }
   },
   "dependencies": {
-    "ajv": "6.10.0",
-    "async": "3.0.0",
-    "chalk": "2.4.2",
-    "cosmiconfig": "5.2.1",
-    "debug": "4.1.1",
+    "ajv": "8.6.1",
+    "async": "3.2.0",
+    "chalk": "4.1.1",
+    "cosmiconfig": "7.0.0",
+    "debug": "4.3.2",
     "hyperlinker": "1.0.0",
-    "log-symbols": "3.0.0",
-    "optionator": "0.8.2",
-    "ora": "3.4.0",
+    "log-symbols": "4.1.0",
+    "optionator": "0.9.1",
+    "ora": "5.4.1",
     "pluralize": "8.0.0",
     "requireindex": "1.2.0",
-    "strip-ansi": "5.2.0",
-    "supports-hyperlinks": "2.0.0",
+    "strip-ansi": "6.0.0",
+    "supports-hyperlinks": "2.2.0",
     "text-table": "0.2.0"
   },
   "repository": {

src/cli/bin/adviser.js

@@ -23,7 +23,7 @@ process.once('uncaughtException', errorHandler.onError);
 if (isInitEnabled) {
   init.createTemplate();
 } else {
-  cli.execute(process.argv, exitCode => {
+  cli.execute(process.argv, (exitCode) => {
     process.exitCode = exitCode;
   });
 }

src/cli/cli.js

@@ -13,7 +13,6 @@ const Engine = require('../core/engine');
 const Formatter = require('../core/formatters/formatter');
 const Spinner = require('./spinner');
 const EVENTS = require('../core/constants/events');
-
 const options = require('./options');
 const logger = require('../utils/logger');
 const packageInfo = require('../package-info');
@@ -57,12 +56,12 @@ class CLI {
       debug(`Parsing CLI arguments ${JSON.stringify(currentOptions)} for the engine`);
       const engineOptions = this._prepareEngineOptions(currentOptions);
 
-      const config = new Config(engineOptions['configFile'] || engineOptions.cwd);
+      const config = new Config(engineOptions.configFile || engineOptions.cwd);
       debug(`Engine called with the parameters ${JSON.stringify(engineOptions)}`);
       const engine = new Engine(config, engineOptions);
 
       if (!currentOptions.debug) {
-        console.log(`Adviser v${packageInfo.getVersion()}\n`);
+        console.log(`Adviser v${packageInfo.getVersion()}\n`); // eslint-disable-line
 
         const spinner = new Spinner();
 
@@ -87,7 +86,7 @@ class CLI {
           if (issues.items.length > 0) {
             this.printResults(issues, processedRules, {
               format: engineOptions.outputFormat,
-              verbose: currentOptions.verbose
+              verbose: currentOptions.verbose,
             });
 
             errorCode = 2;
@@ -100,19 +99,20 @@ class CLI {
           if (currentOptions.verbose) {
             if (issues.items.length > 0) {
               this.printResults(issues, processedRules, {
-                format: 'verbose'
+                format: 'verbose',
               });
             }
 
             if (processedRules.length > 0) {
               this.printResults(issues, processedRules, {
-                format: 'summary'
+                format: 'summary',
               });
             }
           } else {
-            const verboseResults = issues.items.filter(result => result.params.verbose !== undefined);
+            const verboseResults = issues.items.filter((result) => result.params.verbose !== undefined);
 
             if (verboseResults.length >= 1) {
+              // eslint-disable-next-line
               console.log(
                 `Some rules reported a verbose result, call Adviser with ${chalk.gray('--verbose')} for more details.\n`
               );
@@ -121,7 +121,7 @@ class CLI {
 
           callback(errorCode);
         })
-        .catch(error => {
+        .catch((error) => {
           logger.error('Some rules has failed the run', error);
           callback(errorCode);
         });
@@ -155,11 +155,11 @@ class CLI {
     const engineOptions = {
       outputFormat: 'base',
       cwd: process.cwd(),
-      verboseMode: cliOptions['verbose'] || false
+      verboseMode: cliOptions.verbose || false,
     };
 
-    cliOptions.config && (engineOptions['configFile'] = cliOptions.config);
-    cliOptions.tags && (engineOptions['tags'] = cliOptions.tags);
+    cliOptions.config && (engineOptions.configFile = cliOptions.config);
+    cliOptions.tags && (engineOptions.tags = cliOptions.tags);
 
     return engineOptions;
   }

src/cli/init.js

@@ -6,6 +6,7 @@
 'use strict';
 
 const fs = require('fs');
+
 const chalk = require('chalk');
 const debug = require('debug')('adviser:cli-init');
 
@@ -18,7 +19,7 @@ const logger = require('../utils/logger');
 function createTemplate() {
   debug(`Creating file .adviserrc in the path ${process.cwd()}`);
   const adviserInitConfigFileTemplate = require('../core/config/data/init-config-file-template.json');
-  fs.writeFile('.adviserrc', JSON.stringify(adviserInitConfigFileTemplate, null, 4), function(err) {
+  fs.writeFile('.adviserrc', JSON.stringify(adviserInitConfigFileTemplate, null, 4), function (err) {
     if (err) throw err;
     logger.info(
       `Adviser created a base configuration file called ${chalk.yellow('.adviserrc')} with the following structure:`
@@ -29,5 +30,5 @@ function createTemplate() {
 }
 
 module.exports = {
-  createTemplate
+  createTemplate,
 };

src/cli/options.js

@@ -12,67 +12,67 @@ module.exports = optionator({
   prepend: `adviser ${chalk.red('[options]')}`,
   defaults: {
     concatRepeatedArrays: true,
-    defaults: Object
+    defaults: Object,
   },
   options: [
     {
-      heading: chalk.yellow('Basic configuration')
+      heading: chalk.yellow('Basic configuration'),
     },
     {
       option: 'config',
       alias: 'c',
       type: 'Path',
-      description: chalk.cyan('Specify config file path')
+      description: chalk.cyan('Specify config file path'),
     },
     {
-      heading: chalk.yellow('Output')
+      heading: chalk.yellow('Output'),
     },
     {
       option: 'verbose',
       type: 'Boolean',
-      description: chalk.cyan('More information on runtime')
+      description: chalk.cyan('More information on runtime'),
     },
     {
-      heading: chalk.yellow('Warnings')
+      heading: chalk.yellow('Warnings'),
     },
     {
       option: 'quiet',
       type: 'Boolean',
-      description: chalk.cyan('Report errors only - default: false')
+      description: chalk.cyan('Report errors only - default: false'),
     },
     {
-      heading: chalk.yellow('Funcionality')
+      heading: chalk.yellow('Funcionality'),
     },
     {
       option: 'tags',
       alias: 't',
       type: '[String]',
-      description: chalk.cyan('Specify list of tags; e.g fast,perf,pkg')
+      description: chalk.cyan('Specify list of tags; e.g fast,perf,pkg'),
     },
     {
-      heading: chalk.yellow('Miscellaneous')
+      heading: chalk.yellow('Miscellaneous'),
     },
     {
       option: 'init',
       type: 'Boolean',
-      description: chalk.cyan('Run config initialization wizard')
+      description: chalk.cyan('Run config initialization wizard'),
     },
     {
       option: 'debug',
       type: 'Boolean',
-      description: chalk.cyan('Output debugging information')
+      description: chalk.cyan('Output debugging information'),
     },
     {
       option: 'help',
       alias: 'h',
       type: 'Boolean',
-      description: chalk.cyan('Show help')
+      description: chalk.cyan('Show help'),
     },
     {
       option: 'version',
       alias: 'v',
       type: 'Boolean',
-      description: chalk.cyan('Output the version number')
-    }
-  ]
+      description: chalk.cyan('Output the version number'),
+    },
+  ],
 });

src/cli/spinner.js

@@ -35,7 +35,7 @@ class Spinner {
     if (stopState) {
       this.spinner.stopAndPersist({
         symbol: logSymbols.success,
-        text: stopState
+        text: stopState,
       });
     }
 

src/core/built-in/rules/package-json-properties.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const path = require('path');
+
 const pluralize = require('pluralize');
 
 const Rule = require('../../external/rule');
@@ -10,46 +11,50 @@ class PackageJsonProperties extends Rule {
   constructor(context) {
     super(context);
 
-    if (!this.context.options['required'] && !this.context.options['blacklist']) {
+    if (!this.context.options.required && !this.context.options.blacklist) {
       throw new Error(`The rule must have at least one option, "required" or "blacklist"`);
     }
 
-    if (this.context.options['required'] && !Array.isArray(this.context.options['required'])) {
+    if (this.context.options.required && !Array.isArray(this.context.options.required)) {
       throw new Error(`Wrong "required" argument, an array is expected`);
     }
 
-    if (this.context.options['blacklist'] && !Array.isArray(this.context.options['blacklist'])) {
+    if (this.context.options.blacklist && !Array.isArray(this.context.options.blacklist)) {
       throw new Error(`Wrong "blacklist" argument, an array is expected`);
     }
   }
 
   run(sandbox) {
     const packagejson = this._getPackageJsonPath();
 
-    const requiredProps = this.context.options['required'];
+    const requiredProps = this.context.options.required;
     if (requiredProps) {
-      const missingProps = requiredProps.filter(requiredProp => !packagejson.hasOwnProperty(requiredProp));
+      const missingProps = requiredProps.filter(
+        (requiredProp) => !Object.prototype.hasOwnProperty.call(packagejson, requiredProp)
+      );
 
       if (missingProps.length > 0) {
         sandbox.report({
           message: `The package.json is missing the required ${pluralize(
             'property',
             missingProps.length
-          )}: ${missingProps.join(', ')}`
+          )}: ${missingProps.join(', ')}`,
         });
       }
     }
 
-    const blacklistedProps = this.context.options['blacklist'];
+    const blacklistedProps = this.context.options.blacklist;
     if (blacklistedProps) {
-      const notAllowedProps = blacklistedProps.filter(blacklistedProp => packagejson.hasOwnProperty(blacklistedProp));
+      const notAllowedProps = blacklistedProps.filter((blacklistedProp) =>
+        Object.prototype.hasOwnProperty.call(packagejson, blacklistedProp)
+      );
 
       if (notAllowedProps.length > 0) {
         sandbox.report({
           message: `The package.json includes the restricted ${pluralize(
             'property',
             notAllowedProps.length
-          )}: ${notAllowedProps.join(', ')}`
+          )}: ${notAllowedProps.join(', ')}`,
         });
       }
     }
@@ -73,7 +78,7 @@ PackageJsonProperties.meta = {
   description: 'Property restrictions over package.json',
   recommended: true,
   docsUrl: docs.getURL('package-json-properties'),
-  tags: ['quick', 'packagejson']
+  tags: ['quick', 'packagejson'],
 };
 
 module.exports = PackageJsonProperties;