Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust MarkdownTextInput ref type #523

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: adjust MarkdownTextInput ref type #523

merged 2 commits into from
Oct 18, 2024

Conversation

TheKohan
Copy link
Contributor

@TheKohan TheKohan commented Oct 18, 2024 •
edited
Loading

  • Adjusted ref type of MarkdownTextInput, previously you would have to feed TextInput into useRef

Fixes: #487

@TheKohan TheKohan changed the title fix: adjust markdowninput ref type fix: adjust MarkdownTextInput ref type Oct 18, 2024
tomekzaw
tomekzaw approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw merged commit f171853 into Expensify:main Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@Skalakid Skalakid Skalakid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix MarkdownTextInput React ref type
3 participants
@TheKohan @tomekzaw @Skalakid