Fix keyboard flickering and bad typing behavior while typing password in revealed state for a protected PDF #55130
+1
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Typing was not smooth while typing the password in the revealed state for protected PDFs. The reason was that the rapidly changing keyboard caused the keyboard to flicker when the password was revealed.
I've removed the
getSecureEntryKeyboardType
method for native Android, which was forcingkeyboard-type='visible-password'
, which causes the keyboard to flicker.Fixed Issues
$ #53394
PROPOSAL: $ #53394 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
TestOnAndroidApp.mp4
Android: mWeb Chrome
TestOnAndroidChrome.mp4
iOS: Native
TestOnIOSApp.mov
iOS: mWeb Safari
TestOnSafariIOS.1.mov
MacOS: Chrome / Safari
TestOnMacSafari.mov
MacOS: Desktop
TestOnMacDesktopApp.mov