Revert removal of the receipt
param
#55126
Open
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Reverts removal of the
receipt
param inCategorizeTrackedExpense
andShareTrackedExpense
commands by #54628. Turns out it is actually needed 😃Also adds
receipt instanceof Blob ? receipt : undefined
check similar to the original PR.Fixed Issues
$ #55120
PROPOSAL:
Tests
Same as QA Steps
Offline tests
N/A
QA Steps
.
.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
55120.android.native.mp4
Android: mWeb Chrome
55120.android.chrome.mp4
iOS: Native
55120.ios.native.mp4
iOS: mWeb Safari
55120.ios.safari.mp4
MacOS: Chrome / Safari
55120.macos.chrome.mov
MacOS: Desktop
55120.macos.desktop.mov