Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Support empty value for categories and tags" #51015

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[CP Staging] Revert "Support empty value for categories and tags" #51015

merged 1 commit into from
Oct 17, 2024
+14 −73

Conversation

mjasikowski
Copy link
Contributor

@mjasikowski mjasikowski commented Oct 17, 2024 •
edited
Loading

Straight revert of #50122 to fix #50984

@mjasikowski mjasikowski marked this pull request as ready for review October 17, 2024 13:20
@mjasikowski mjasikowski requested a review from a team as a code owner October 17, 2024 13:20
@mjasikowski mjasikowski changed the title Revert "Support empty value for categories and tags" [CP Staging] Revert "Support empty value for categories and tags" Oct 17, 2024
@melvin-bot melvin-bot bot requested review from carlosmiceli and removed request for a team October 17, 2024 13:20
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 17, 2024

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mjasikowski mjasikowski merged commit ce400f7 into main Oct 17, 2024
14 of 18 checks passed
@mjasikowski mjasikowski deleted the revert-50122-cmartins-addNoOperator branch October 17, 2024 13:30
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 17, 2024

@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Oct 17, 2024
@mjasikowski
Copy link
Contributor Author

Straight revert for CP, no checklists needed

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 17, 2024
@mjasikowski @OSBotify
Merge pull request #51015 from Expensify/revert-50122-cmartins-addNoO…
37f7086 
…perator

[CP Staging] Revert "Support empty value for categories and tags"

(cherry picked from commit ce400f7)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 17, 2024
@289Adam289 289Adam289 mentioned this pull request Oct 17, 2024
Closed
8 tasks
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Closed
90 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.50-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@luacmartins luacmartins mentioned this pull request Oct 17, 2024
Merged
50 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioExpensify MarioExpensify MarioExpensify approved these changes

@carlosmiceli carlosmiceli Awaiting requested review from carlosmiceli

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search - Search doesn't show expenses when applied tag filters
3 participants
@mjasikowski @OSBotify @MarioExpensify