[Debug Mode] Add transaction and violation data to debug mode #50745
+1,166
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
|
I didn't have much time as I wanted to work on this today but here goes my update! Today's update:
Todo:
|
…and-violation-data-to-debug-mode # Conflicts: # src/libs/DebugUtils.ts
|
Today's update:
Todo:
|
|
Today's update:
Todo:
|
…and-violation-data-to-debug-mode
|
Today's update:
Todo:
|
…and-violation-data-to-debug-mode
…bug transaction violations tab
…and-violation-data-to-debug-mode # Conflicts: # src/libs/DebugUtils.ts
|
Today's update:
Todo:
|
…and-violation-data-to-debug-mode
… transaction violations form types
…and-violation-data-to-debug-mode
|
Today's update:
Todo:
|
…and-violation-data-to-debug-mode
pac-guerreiro
changed the title
melvin-bot
bot
requested review from
DylanDylann
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The PR is now ready for review 😄 |
|
@pac-guerreiro Type errors please |
…and-violation-data-to-debug-mode
fabioh8010
reviewed
Oct 24, 2024
| @@ -21,9 +22,11 @@ type ConstantSelectorProps = { | |||
| /** inputID used by the Form component */ | |||
| // eslint-disable-next-line react/no-unused-prop-types | |||
| inputID: string; | |||
|
|
|||
| formType: ValueOf<typeof CONST.DEBUG.FORMS>; | |||
There was a problem hiding this comment.
Please add prop description
| import {DETAILS_CONSTANT_FIELDS, DETAILS_DATETIME_FIELDS, DETAILS_DISABLED_KEYS} from './const'; | ||
| import ConstantSelector from './ConstantSelector'; | ||
| import DateTimeSelector from './DateTimeSelector'; | ||
|
|
||
| type DebugDetailsProps = { | ||
| formType: ValueOf<typeof CONST.DEBUG.FORMS>; |
There was a problem hiding this comment.
Please add prop description
| }; | ||
|
|
||
| function DebugTransactionViolations({transactionID}: DebugTransactionViolationsProps) { | ||
| const [transactionViolations] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {}); |
There was a problem hiding this comment.
Suggested change
| const [transactionViolations] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {}); | |
| const [transactionViolations] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`); |
Comment on lines
96
to
106
| onChangeText={(updatedJSON) => { | ||
| try { | ||
| DebugUtils.validateTransactionViolationJSON(updatedJSON); | ||
| setError(''); | ||
| } catch (e) { | ||
| const {cause, message} = e as SyntaxError; | ||
| setError(cause ? translate(message as TranslationPaths, cause as never) : message); | ||
| } finally { | ||
| setDraftTransactionViolation(updatedJSON); | ||
| } | ||
| }} |
There was a problem hiding this comment.
Could you extract this into separate function?
Comment on lines
115
to
119
| onPress={() => { | ||
| const parsedTransactionViolation = DebugUtils.stringToOnyxData(draftTransactionViolation, 'object') as TransactionViolation; | ||
| Debug.mergeDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, [...(transactionViolations ?? []), parsedTransactionViolation]); | ||
| Navigation.navigate(ROUTES.DEBUG_TRANSACTION_TAB_VIOLATIONS.getRoute(transactionID)); | ||
| }} |
Comment on lines
62
to
71
| onSave={(data) => { | ||
| const updatedTransactionViolations = [...(transactionViolations ?? [])]; | ||
| updatedTransactionViolations.splice(Number(index), 1, data as TransactionViolation); | ||
| Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, updatedTransactionViolations); | ||
| }} | ||
| onDelete={() => { | ||
| const updatedTransactionViolations = [...(transactionViolations ?? [])]; | ||
| updatedTransactionViolations.splice(Number(index), 1); | ||
| Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, updatedTransactionViolations); | ||
| }} |
| @@ -271,7 +294,7 @@ function validateBoolean(value: string) { | |||
| * Validates if a string is a valid representation of a date. | |||
| */ | |||
| function validateDate(value: string) { | |||
There was a problem hiding this comment.
Did you update the unit tests to cover the changes?
There was a problem hiding this comment.
I did not but I'll confirm if it's needed, thanks! 😄
| @@ -355,8 +378,8 @@ function validateArray( | |||
| /** | |||
| * Validates if a string is a valid representation of an object. | |||
| */ | |||
| function validateObject(value: string, type: ObjectType, collectionIndexType?: 'string' | 'number') { | |||
| if (value === 'undefined') { | |||
| function validateObject<T extends Record<string, unknown>>(value: string, type: ObjectType<T>, collectionIndexType?: 'string' | 'number') { | |||
There was a problem hiding this comment.
Did you update the unit tests to cover the changes?
There was a problem hiding this comment.
I did not but I'll confirm if it's needed, thanks! 😄
|
@DylanDylann typecheck errors were resolved 😄 |
…and-violation-data-to-debug-mode # Conflicts: # tests/utils/collections/transaction.ts
|
@fabioh8010 all feedback addressed, thanks! 😄 Still waiting for @DylanDylann review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$#50335
PROPOSAL:
Tests
View transactionin details tabdetails,jsonandviolationstabsdetailstab is saved correctlyviolationstab, try creating and modifying a violation and check that the UI shows your changes in real timeOffline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.-.Native.mp4
Android: mWeb Chrome
Android.-.Chrome.mp4
iOS: Native
iOS.-.Native.mp4
iOS: mWeb Safari
iOS.-.Safari.mp4
MacOS: Chrome / Safari
MacOS.-.Chrome.mp4
MacOS: Desktop
MacOS.-.Native.mp4