-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show existing reports while loading #25159
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4da6777
fix: show existing reports while loading
sangar-1028 f36ca39
fix: minor refactoring
sangar-1028 d8a65a2
Merge branch 'main' into fix/issue-24596
sangar-1028 de433a4
fix: LHN glitch
sangar-1028 01dda2f
Merge branch 'main' into fix/issue-24596
sangar-1028 503af34
fix: remove unnecessary condition'
sangar-1028 b35a98f
fix: initial value to null
sangar-1028 8058d02
fix: conflicts
sangar-1028 e8322ca
fix: lint error
sangar-1028 7ffa793
fix: add comments
sangar-1028 bce3738
fix: default style of LHNOptionsList
sangar-1028 e73cc36
Merge branch 'main' into fix/issue-24596
sangar-1028 261b811
Merge branch 'main' into fix/issue-24596
sangar-1028 2734584
fix: same behavior on all platforms
sangar-1028 7c0f96b
fix: lint error
sangar-1028 52070c8
fix: lint error
sangar-1028 54bfb83
fix: conflicts
sangar-1028 2d85e65
fix: update comments
sangar-1028 243844e
fix: simplify conditions
sangar-1028 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you can move this to 78 line too like if (long condition || !isLoading)