Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed
79 tasks done
OSBotify opened this issue Aug 1, 2023 · 21 comments
Closed
79 tasks done

Deploy Checklist: New Expensify 2023-08-01 #24028

OSBotify opened this issue Aug 1, 2023 · 21 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

Release Version: 1.3.49-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 2, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 2, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.49-0 🚀

@Beamanator
Copy link
Contributor

Created new section PRs from old checklists that shouldn't be here (https://github.com/Expensify/App/issues/23368): for PRs that were already tested on previous checklists & are now in production & I checked them off (as discussed internally here)

@puneetlath
Copy link
Contributor

Checking off #24005. It was handled yesterday, we just never removed the label.

@hayata-suenaga
Copy link
Contributor

Checking off #24063 the fix pr has been cherry picked

@Li357
Copy link
Contributor

Li357 commented Aug 2, 2023

Checking off #24077 because there is agreement this isn't really an issue.

@mvtglobally
Copy link

#23531 is failing #24077
#23707 is failing #24069

@Beamanator
Copy link
Contributor

Beamanator commented Aug 3, 2023

#24069 marked NAB, checking it off & associated PR, #23707

@Beamanator
Copy link
Contributor

Checking off #24092 b/c it was fixed by #24097

@mvtglobally
Copy link

mvtglobally commented Aug 3, 2023

@Beamanator Regression is completed

Summary
#22467 is failing #24105
#22912 is failing with old KI ttps://github.com/Expensify/App/issues/12249. Ok to check off?
#23531 is failing #24077
#23707 is failing #24069
#23915 is failing #24063
#23983 blocked on web/mWeb,Desktop due to #24063 , ok to check off?
#23975 is PROD QA, ok to check off?

@Beamanator
Copy link
Contributor

Thanks @mvtglobally ! Just checking, it looks like there's 3 untested tests in testrail - https://expensify.testrail.io/index.php?/plans/view/16715

  • Is that expected?

@Beamanator
Copy link
Contributor

Checking off #24112 since workspace chats are still in beta

@mvtglobally
Copy link

@Beamanator We are done. These were duplicates. Updated

@Beamanator
Copy link
Contributor

#22912 can be checked off since it's only failing the super old bug: #12249

#24105 is supposedly reproducible in production, so we can check off #22467

#23531 can be checked off b/c #24077 was closed and marked not something we need to fix

#23707 can be marked off b/c #24069 was marked not a blocker

#23915 can be marked off b/c #24063 was fixed by #24036 & it was CP'd

@mvtglobally is it possible to get #23983 re-tested due to the fix that went in place yesterday ^?

@mvtglobally are help pages always prod QA? (for #23975)

@Beamanator
Copy link
Contributor

Help sites deploy immediately apparently, so checked #23975 and it looks good on the help site

@mvtglobally
Copy link

@Beamanator
retesting #23983
and Yes, we usually check off Help pages

@Beamanator
Copy link
Contributor

Amazing, thank you 🙏

@Beamanator
Copy link
Contributor

@mvtglobally looks like the last deploy blocker fix is on staging now, so we're just waiting on the retest of #23983 ! 👍

@Beamanator
Copy link
Contributor

Checking off #24085 b/c fix is on staging & passing!

@mvtglobally
Copy link

@Beamanator #23983
its pass on Web, Native apps.. validating mWeb and Desktop now

@mvtglobally
Copy link

@Beamanator We are done, checked off

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants