Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy checklist is listing PRs from 2-3 previous builds #24030

Closed
mvtglobally opened this issue Aug 2, 2023 · 24 comments
Closed

Deploy checklist is listing PRs from 2-3 previous builds #24030

mvtglobally opened this issue Aug 2, 2023 · 24 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@mvtglobally
Copy link

mvtglobally commented Aug 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Navigate to the current Deploy checklist. e.g. Deploy Checklist: New Expensify 2023-08-01 #24028
  2. Check the PRs listed
  3. CP PR
  4. Observe if CP is added to the checklist

Expected Result:

Only PRs deployed in the build should be listed
CPs should be added to the checklist once deployed

Actual Result:

Multiple PRs from previous deploys displayed in the checklist even after they were already deployed to PROD.
Once CP is deployed, its not added to the checklist

Workaround:

unknown

Notes/Photos/Videos: Any additional supporting documentation

Screen Shot 2023-08-01 at 10 08 02 PM

Expensify/Expensify Issue URL:
Issue reported by: Applause Testing Team
Slack conversation:
https://expensify.slack.com/archives/C9YU7BX5M/p1690509355423659
https://expensify.slack.com/archives/C9YU7BX5M/p1690256275653639
https://expensify.slack.com/archives/C9YU7BX5M/p1689965139270719
https://expensify.slack.com/archives/C9YU7BX5M/p1690935729223149

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0158becf89864f9a24
  • Upwork Job ID: 1686796943040983040
  • Last Price Increase: 2023-08-02
@mvtglobally mvtglobally added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn
Copy link
Contributor

Not sure if this should be external - I assume it needs to be internal? Going to add internal and we can adjust if needed.

@Christinadobrzyn Christinadobrzyn added the Internal Requires API changes or must be handled by Expensify staff label Aug 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0158becf89864f9a24

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@Christinadobrzyn
Copy link
Contributor

@0xmiroslav can you take a peek if this should be internal or external when you have time? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Aug 4, 2023

@Christinadobrzyn this should be internal. Can you please add Engineering label?

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Christinadobrzyn
Copy link
Contributor

Thanks for confirming @0xmiroslav added the engineering label

@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2023

@puneetlath, @Christinadobrzyn, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Christinadobrzyn
Copy link
Contributor

looks like #23179 might be related.

@0xmiroslav feel free to add any updates on this one!

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Aug 10, 2023

#23179 doesn't help. It's just one example affected by this issue.
I don't have much context on deploy process.
Need help from @puneetlath

@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 14, 2023

Not sure about an update on this one - @0xmiroslav what questions do you have for @puneetlath? Can you provide them here or in a Slack convo?

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2023
@Christinadobrzyn
Copy link
Contributor

Just nudging this for an update @puneetlath or @0xmiroslav?

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

@puneetlath, @Christinadobrzyn, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

@puneetlath, @Christinadobrzyn, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@0xmiros
Copy link
Contributor

0xmiros commented Aug 21, 2023

@mvtglobally can you please tag relevant people to push this forward? I don't have access to slack links in OP.

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 22, 2023

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

@puneetlath @Christinadobrzyn @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@Christinadobrzyn
Copy link
Contributor

Sorry, I've not been great about trying to figure out how to guide this issue. I reached out to the team in Slack to see if I can get some guidance.

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 28, 2023

Just going to make sure this is still a thing as I haven't heard more about it recently - @mvtglobally are you still seeing this issue? Slack - https://expensify.slack.com/archives/C9YU7BX5M/p1693345044647759

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2023
@mvtglobally
Copy link
Author

still happening on the latest checklist #26113 (comment)

@thienlnam
Copy link
Contributor

cc @roryabraham

@roryabraham
Copy link
Contributor

Closing this as a dupe of #21763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants