Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - LHN - Free space below FAB modal window #14110

Closed
1 task
kbecciv opened this issue Jan 7, 2023 · 14 comments
Closed
1 task

Android - LHN - Free space below FAB modal window #14110

kbecciv opened this issue Jan 7, 2023 · 14 comments

Comments

@kbecciv
Copy link

kbecciv commented Jan 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login with any account
  3. Tap on FAB button (1-st issue)
  4. Go to any chat
  5. Tap on "+" button (2-nd issue)
  6. Tap on Emoji (3-nd issue)

Expected Result:

No free space below

Actual Result:

Free space below

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 7, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 7, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Jan 7, 2023

NOTE: this issue is specific to #13767 (comment) CC @WoLewicki

@mvtglobally mvtglobally removed the DeployBlockerCash This issue or pull request should block deployment label Jan 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2023
@techievivek techievivek added Daily KSv2 and removed Hourly KSv2 labels Jan 9, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2023
@techievivek
Copy link
Contributor

Not overdue, I will try reproducing this.

@Julesssss
Copy link
Contributor

Hey @techievivek, this is an unique report because it is from a new React native architecture branch -- so Software Mansion are handling this

@Expensify Expensify unlocked this conversation Jan 9, 2023
@j-piasecki
Copy link
Contributor

Hello, I will be working on this issue.

@WoLewicki
Copy link
Contributor

Me too

@Julesssss
Copy link
Contributor

Assigned you both

@j-piasecki
Copy link
Contributor

WoLewicki@2d98d4e should fix the problem.

@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2023

@j-piasecki, @WoLewicki Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

@j-piasecki, @WoLewicki Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Jan 19, 2023

@j-piasecki, @WoLewicki Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 6, 2023
@MelvinBot
Copy link

This issue has not been updated in over 14 days. @j-piasecki, @WoLewicki eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 1, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @j-piasecki, @WoLewicki eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

@j-piasecki, @WoLewicki, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants