Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-01-06 #14067

Closed
36 tasks done
OSBotify opened this issue Jan 6, 2023 · 11 comments
Closed
36 tasks done

Deploy Checklist: New Expensify 2023-01-06 #14067

OSBotify opened this issue Jan 6, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2023

Release Version: 1.2.50-14
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 6, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 7, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 7, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.50-13 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 9, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.50-14 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 9, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.50-14 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

Checking off #14089, #14110, #14111 as they were reported against a unique Software mansion build (see this comment for more details).

@Julesssss
Copy link
Contributor

Checking off #14121, as it was resolved by this cherry-picked PR

@Julesssss
Copy link
Contributor

For #14065 I have asked for a contributor to verify the fix.

@Julesssss Julesssss self-assigned this Jan 9, 2023
@Julesssss
Copy link
Contributor

#14065 didn't appear to resolve the Contributor issue, but I'm checking it off as this should not be a blocker and will need another follow-up PR.

@Julesssss
Copy link
Contributor

Marked off #12457 as it needs to be tested on prod.

@mvtglobally
Copy link

mvtglobally commented Jan 9, 2023

@Julesssss Regression is completed

PR #13185 is failing #14130. repro in PROD checking off
PR #13958 is failing #14118. repro in PORD checking off
PR #13994 is failing #14137 & #14126. #14137 is a new feature not repro in PROD. pls double check if ok to check it off.

@Expensify Expensify unlocked this conversation Jan 9, 2023
@Julesssss
Copy link
Contributor

Julesssss commented Jan 9, 2023

Thanks @mvtglobally. I agree with your assessment and I'm going to make the release

@Julesssss
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants