feat!: STREAMP-9951: spring 3 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 31, 2023 16:26
pom.xml
Outdated
| @@ -72,19 +72,19 @@ | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
| <jdk.version>8</jdk.version> | |||
There was a problem hiding this comment.
Can we delete this? 🤔
Suggested change
| <jdk.version>8</jdk.version> |
| @@ -74,7 +78,7 @@ public class AgentIT { | |||
| .pollDelay(1, SECONDS); | |||
|
|
|||
| @Rule | |||
| public KafkaContainer kafka = new KafkaContainer(); | |||
| public KafkaContainer kafka = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:7.2.1")); | |||
There was a problem hiding this comment.
perhaps put the string somewhere it can be shared with StateIT.java?
| import org.testcontainers.utility.DockerImageName; | ||
|
|
||
| public class TestUtils { | ||
| public static DockerImageName kafkaImageName = DockerImageName.parse("confluentinc/cp-kafka:7.4.0"); |
There was a problem hiding this comment.
Minor, would this be more usual idiomatic Java?
Suggested change
| public static DockerImageName kafkaImageName = DockerImageName.parse("confluentinc/cp-kafka:7.4.0"); | |
| public static final DockerImageName KAFKA_IMAGE_NAME = DockerImageName.parse("confluentinc/cp-kafka:7.4.0"); |
techabstraction
approved these changes
Nov 2, 2023
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.