feat: auto approve bot prs #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtayeh
approved these changes
Nov 14, 2024
Mohammad-Dwairi
approved these changes
Nov 14, 2024
mohnoor94
pushed a commit
that referenced
this pull request
Nov 14, 2024
## [1.12.0](v1.11.1...v1.12.0) (2024-11-14) ### Features * auto approve bot prs ([#316](#316)) ([806ab90](806ab90)) * **deps:** update dependencies openapi-to-postmanv2 from v4.22.0 to v4.23.1 ([#288](#288)) ([16456b8](16456b8)) * **deps:** update dependencies openapi-to-postmanv2 from v4.23.1 to v4.24.0 ([#297](#297)) ([c59dfc5](c59dfc5)) * **deps:** update dependencies openapi3-ts from v4.3.3 to v4.4.0 ([#301](#301)) ([7f535e0](7f535e0))
mohnoor94
pushed a commit
that referenced
this pull request
Nov 25, 2024
## [1.12.0](v1.11.1...v1.12.0) (2024-11-25) ### Features * auto approve bot prs ([#316](#316)) ([806ab90](806ab90)) * **deps:** update dependencies openapi-to-postmanv2 from v4.22.0 to v4.23.1 ([#288](#288)) ([16456b8](16456b8)) * **deps:** update dependencies openapi-to-postmanv2 from v4.23.1 to v4.24.0 ([#297](#297)) ([c59dfc5](c59dfc5)) * **deps:** update dependencies openapi3-ts from v4.3.3 to v4.4.0 ([#301](#301)) ([7f535e0](7f535e0))
mohnoor94
pushed a commit
that referenced
this pull request
Dec 2, 2024
## [1.12.0](v1.11.1...v1.12.0) (2024-12-02) ### Features * auto approve bot prs ([#316](#316)) ([806ab90](806ab90)) * **deps:** update dependencies openapi-to-postmanv2 from v4.22.0 to v4.23.1 ([#288](#288)) ([16456b8](16456b8)) * **deps:** update dependencies openapi-to-postmanv2 from v4.23.1 to v4.24.0 ([#297](#297)) ([c59dfc5](c59dfc5)) * **deps:** update dependencies openapi3-ts from v4.3.3 to v4.4.0 ([#301](#301)) ([7f535e0](7f535e0))
mohnoor94
pushed a commit
that referenced
this pull request
Dec 10, 2024
## [1.12.0](v1.11.1...v1.12.0) (2024-12-10) ### Features * auto approve bot prs ([#316](#316)) ([806ab90](806ab90)) * **deps:** update dependencies openapi-to-postmanv2 from v4.22.0 to v4.23.1 ([#288](#288)) ([16456b8](16456b8)) * **deps:** update dependencies openapi-to-postmanv2 from v4.23.1 to v4.24.0 ([#297](#297)) ([c59dfc5](c59dfc5)) * **deps:** update dependencies openapi3-ts from v4.3.3 to v4.4.0 ([#301](#301)) ([7f535e0](7f535e0))
mohnoor94
pushed a commit
that referenced
this pull request
Dec 16, 2024
## [1.12.0](v1.11.1...v1.12.0) (2024-12-16) ### Features * auto approve bot prs ([#316](#316)) ([806ab90](806ab90)) * **deps:** update dependencies openapi-to-postmanv2 from v4.22.0 to v4.23.1 ([#288](#288)) ([16456b8](16456b8)) * **deps:** update dependencies openapi-to-postmanv2 from v4.23.1 to v4.24.0 ([#297](#297)) ([c59dfc5](c59dfc5)) * **deps:** update dependencies openapi3-ts from v4.3.3 to v4.4.0 ([#301](#301)) ([7f535e0](7f535e0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The repository currently requires 2 approvals for all pull requests. However, to reduce friction, only 1 approval should be required for pull requests made by bot accounts like Dependabot and Renovate.
Task
The goal is to configure the repository to automatically provide the first approval for pull requests made by trusted bot accounts while requiring a second human approval before merging.
Action
A GitHub Actions workflow was created in the
.github/workflows/pr-auto-approve.ymlfile. This workflow:hmarr/auto-approve-actionTesting
Tested manually on another repo.
Results
With this configuration, pull requests from trusted bot accounts will only require 1 additional human approval before merging, instead of the usual 2. This reduces friction for routine updates while maintaining a level of human review.