fix: regex match for keys rule (#180)

ExpediaGroup · May 25, 2023 · 4356c36 · 4356c36
1 parent b1720d4
commit 4356c36
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/rules/keys.ts b/src/rules/keys.ts
@@ -20,7 +20,7 @@ export const validateKeys = (packageJson: PackageJson, packageJsonPath: string)
   const dependencies = getDependencies(packageJson);
   Object.keys(dependencies).forEach(dependency => {
     const stringifiedPackageJson = readFileSync(packageJsonPath).toString();
-    const regexMatches = stringifiedPackageJson.match(new RegExp(dependency, 'g'));
+    const regexMatches = stringifiedPackageJson.match(new RegExp(`"${dependency}"`, 'g'));
     if (regexMatches && regexMatches.length > 1) {
       core.setFailed(`Duplicate keys found in package.json: ${regexMatches}`);
     }

diff --git a/test/fixtures/deduped-package.json b/test/fixtures/deduped-package.json
@@ -1,9 +1,9 @@
 {
   "dependencies": {
     "some-dependency": "1.0.0",
-    "some-other-dependency": "2.0.0"
+    "some-dependency-2": "2.0.0"
   },
   "devDependencies": {
-    "some-dev-dependency": "2.0.0"
+    "some-dependency-3": "2.0.0"
   }
 }
diff --git a/test/fixtures/duped-package2.json b/test/fixtures/duped-package2.json
@@ -1,7 +1,7 @@
 {
   "dependencies": {
     "some-dependency": "1.0.0",
-    "some-other-dependency": "2.0.0"
+    "some-dependency-2": "2.0.0"
   },
   "devDependencies": {
     "some-dependency": "2.0.0"